Bug 50884 – Password change message on SAML login - no link when displayed in german

Bug 50884 - Password change message on SAML login - no link when displayed in german


Summary:	Password change message on SAML login - no link when displayed in german

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	SAML
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-3-errata
Assigned To:	Erik Damrose
QA Contact:	Jürn Brodersen

URL:
Keywords:

Duplicates:	50892 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-02-28 15:43 CET by Erik Damrose
Modified:	2020-03-24 10:01 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.114
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2020022721000388
Bug group (optional):	Regression, Typo/text changes, Usability, Workaround is available
Max CVSS v3 score:

Attachments
missing link in reset password message (22.31 KB, image/png) 2020-02-28 15:45 CET, Erik Damrose	Details
Same error in English (21.11 KB, image/png) 2020-03-03 15:41 CET, Valentin Heidelberger	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erik Damrose

2020-02-28 15:43:29 CET

At the original bug a message with a link to the password change page was introduced. However, when using a german locale when the message is displayed, the link attribute does not contain any text, so the link is not shown and not clickable, see screenshot.

The issue is that in the translation file errors.translation.json the text is marked for 'en' locale instead of 'de'; Package is univention-saml, Bug occurs with UCS 4.4-3e443 and higher (because german translation was broken until bug 50619 was fixed).

Workaround: sed -i 's/\"en\":/\"de\":/g' /usr/share/simplesamlphp/modules/univentiontheme/dictionaries/errors.translation.json

+++ This bug was initially created as a clone of Bug #50594 +++

Comment 1 Erik Damrose

2020-02-28 15:45:02 CET

Created attachment 10300 [details]
missing link in reset password message

Comment 2 Erik Damrose

2020-03-03 14:36:59 CET

*** Bug 50892 has been marked as a duplicate of this bug. ***

Comment 3 Valentin Heidelberger

2020-03-03 15:41:52 CET

Created attachment 10302 [details]
Same error in English

The problem happens with an english locale too. The workaround does not work for that.

Comment 4 Valentin Heidelberger

2020-03-06 16:07:30 CET

(In reply to Valentin Heidelberger from comment #3)
> Created attachment 10302 [details]
> Same error in English
> 
> The problem happens with an english locale too. The workaround does not work
> for that.

Sorry, seems to have been a caching problem. Workaround works for both DE and EN in my test env.

Comment 5 Erik Damrose

2020-03-12 16:28:41 CET

eb47905c Fix translation errors

univention-saml 6.0.2-25A~4.4.0.202003121622

Comment 6 Jürn Brodersen

2020-03-13 10:16:45 CET

As mentioned in comment 3 this was broken for the english error message as well.

What I tested:
Update -> OK
English error -> OK
German error -> OK
jenkins -> OK
yaml -> OK

-> Verified

Comment 7 Erik Damrose

2020-03-18 12:27:49 CET

<http://errata.software-univention.de/ucs/4.4/490.html>