Bug 50967 - listener-converter is called in infinite loop
listener-converter is called in infinite loop
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.4
Other Linux
: P5 minor (vote)
: UCS 4.4-3-errata
Assigned To: Jannik Ahlers
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-13 16:21 CET by Toni Röhmeyer
Modified: 2020-03-18 12:27 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Röhmeyer univentionstaff 2020-03-13 16:21:54 CET
The univention-appcenter-listener-converter currently gets (intentionally) hooked in a while True loop.
Instead the routine should repeatedly be called by the corresponding systemd service univention-appcenter-listener-converter@.service.
Comment 1 Toni Röhmeyer univentionstaff 2020-03-13 16:44:35 CET
The appcenter-listener-converter now gets called by its systemd service script repeatedly after 5 seconds.
The while True loop was removed.

The behavior was tested with
$ watch systemctl list-units univention-appcenter-listener-converter@oxconnector.service
A change of the ACTIVE status should be observable every 5 seconds from "activating" to "active".


Solution pushed to branch origin/4.4-3 with commits

commit b44daf594e40e61ac52ca1d6a81ae798e20e4aad
Bug #50967: added yaml

commit 735192eb8fbf77240d5eac2f4c7c5e2bd9cef050
Bug #50967: converter now called by service script


waiting for QA
Comment 2 Felix Botner univentionstaff 2020-03-16 09:18:26 CET
80_docker.88_docker_env_file.member096 fails now, please have a look
Comment 3 Dirk Wiesenthal univentionstaff 2020-03-16 09:48:15 CET
As discussed, please remove the log line "Ready" and establish the UDM connection only if there are actually files to process.
Comment 4 Jannik Ahlers univentionstaff 2020-03-16 14:29:27 CET
7996aa71de Bug #50967: yaml
87797a2aef Bug #50967: make listener-converter more performant; remove log messages to avoid spam

Successful build
Package: univention-appcenter
Version: 8.0.11-122A~4.4.0.202003161422
Branch: ucs_4.4-0
Scope: errata4.4-3


- ldap connection only gets established if files are found
- unnecessary log messages removed to avoid spam
- additional cleanup
Comment 5 Felix Botner univentionstaff 2020-03-17 10:06:56 CET
80_docker.73_app_listener_integration still fails
Comment 6 Jannik Ahlers univentionstaff 2020-03-17 15:50:44 CET
I had to fix the test, as the listener converter service now isn't running all the time, but gets restarted by systemd every 5 seconds.

Successful build
Package: ucs-test
Version: 9.0.3-179A~4.4.0.202003171539
Branch: ucs_4.4-0
Scope: errata4.4-3
Comment 7 Felix Botner univentionstaff 2020-03-17 16:39:45 CET
OK - univention-appcenter-listener-converter 
OK - test
OK - yaml
Comment 8 Erik Damrose univentionstaff 2020-03-18 12:27:55 CET
<http://errata.software-univention.de/ucs/4.4/485.html>