Bug 27429 – ucslint 0013-2 bashism: fehlender Typecast → int

Bug 27429 - ucslint 0013-2 bashism: fehlender Typecast → int


Summary:	ucslint 0013-2 bashism: fehlender Typecast → int

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	ucslint
Version:	UCS 3.0
Hardware:	All Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.1
Assigned To:	Philipp Hahn
QA Contact:	Lukas Walter

URL:
Keywords:	interim-2

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-06-01 12:19 CEST by Philipp Hahn
Modified:	2012-12-12 21:09 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	hahn: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philipp Hahn

2012-06-01 12:19:28 CEST

Der Bau von univention-firewall schlägt fehl:

E:0013-2: conffiles/etc/security/packetfilter.d/80_univention-firewall_policy.sh:33: possible bashism (function names should only contain [a-z0-9_]):
policy = configRegistry.get('security/packetfilter/defaultpolicy','ACCEPT').upper()

/usr/share/pyshared/univention/ucslint/0013-bashism.py:
...
 reBashism = re.compile(r'^.*?\s+line\s+(\d+)\s+[(](.*?)[)][:]\n([^\n]+)$')
...
 match = reBashism.search(item)
...
 line = match.group(1)
...
 self.addmsg(..., line=line)

Da fehlt ein int() um line, der ansonsten schlägt der Vergleich "number == linenumber" in /usr/bin/ucslint:157 fehl.

Comment 1 Philipp Hahn

2012-07-20 20:01:24 CEST

Korrigiert.
svn34326, ucslint_3.0.0-1

Comment 2 Lukas Walter

2012-10-15 14:34:10 CEST

(In reply to comment #1)
> Korrigiert.
> svn34326, ucslint_3.0.0-1

Änderung passt.
Changelog in Ordnung.

Comment 3 Stefan Gohmann

2012-12-12 21:09:34 CET

UCS 3.1-0 has been released: 
 http://forum.univention.de/viewtopic.php?f=54&t=2125

If this error occurs again, please use "Clone This Bug".