Bug 27825 - unify threefold implementation of fstab/mtab parsing
unify threefold implementation of fstab/mtab parsing
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: univention-lib
UCS 5.0
All Linux
: P5 enhancement (vote)
: UCS 5.0
Assigned To: Florian Best
Philipp Hahn
:
: 24706 51634 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-04 14:45 CEST by Philipp Hahn
Modified: 2021-05-25 16:00 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments
WIP: /etc/fstab, /etc/mtab, /proc/mounts parser (2.11 KB, text/plain)
2013-09-25 08:57 CEST, Philipp Hahn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2012-07-04 14:45:58 CEST
Derzeit haben wir 2 Implementierungen für das Verarbeiten von /etc/fstab. Die sollten vereinheitlicht werden:

branches/ucs-3.0/ucs/base/univention-lib/python/fstab.py
- kein korrektes Quoting der fstab-Einträge
- fehlende Sonderbehandlung für LABEL= Einträge
- keine Dokumentation
- kein Unittest

branches/ucs-3.0/ucs/base/univention-python/modules/fstab.py
- ggf. fehlende Sonderbahandlung für UUID= und LABEL= Einträge
- wird (anscheinend) derzeit nicht verwendet

Benutzer:
$ git grep -El '(from|import) univention.*fstab'
ucs-school/univention-samba/vampire/mount_extfs_with_user_xattr.py
ucs-school/univention-samba4/scripts/mount_extfs_with_user_xattr.py
ucs/base/univention-quota/umc/python/quota/partition.py
ucs/base/univention-quota/umc/python/quota/tools.py
ucs/base/univention-quota/umc/python/quota/user.py
ucs/services/univention-samba/vampire/mount_extfs_with_user_xattr.py
ucs/services/univention-samba4/scripts/mount_extfs_with_user_xattr.py
Comment 1 Philipp Hahn univentionstaff 2013-09-25 08:57:42 CEST
Created attachment 5468 [details]
WIP: /etc/fstab, /etc/mtab, /proc/mounts parser

3rd implementation from univention-mount-homedir (Bug #31256)
cleaned-up to properly handle octal-encoding.
See "man 3 getmntent" for more information.
Comment 2 Florian Best univentionstaff 2017-02-10 10:45:13 CET
*** Bug 24706 has been marked as a duplicate of this bug. ***
Comment 3 Florian Best univentionstaff 2020-09-19 20:11:54 CEST
univention.fstab has been removed and merged into univention.lib.fstab. The handling of encoding was more correct in univention.fstab while the interface of univention.lib.fstab looks a little better.

univention-lib (9.0.8-0)
1bb280d8d887 | Bug #27825: unify fstab parsers

ucs-test (10.0.1-1)
1bb280d8d887 | Bug #27825: unify fstab parsers

changelog-5.0-0.xml
ffd26905e35b | Changelog Bug #27825
Comment 4 Philipp Hahn univentionstaff 2020-09-25 05:39:57 CEST
OK: ffd26905e35b Changelog
OK: 1bb280d8d887 Code Review
OK: git grep univention.*fstab
OK: ucs-test -s quota -E dangerous -v -c
OK: univention-unittest
Comment 5 Philipp Hahn univentionstaff 2020-10-05 13:12:42 CEST
*** Bug 51634 has been marked as a duplicate of this bug. ***
Comment 6 Florian Best univentionstaff 2021-05-25 16:00:31 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".