Bug 28884 - Falscher Seperator in cupsd.conf Template durch default value in cups/systemgroup
Falscher Seperator in cupsd.conf Template durch default value in cups/systemg...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Printserver
UCS 3.0
Other Linux
: P5 enhancement (vote)
: UCS 3.2
Assigned To: Liam Schwez
Felix Botner
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-23 14:52 CEST by Tim Petersen
Modified: 2013-11-19 06:43 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Petersen univentionstaff 2012-10-23 14:52:29 CEST
Aufgefallen an Ticket #2012102321003749:

"
Ein paar weiter Punkte die mir beim durchsehen der Cups.conf aufgefallen
sind: 

Auf meinem Referenzsystem wird folgende variabel standartmässig gesetzt:   
cups/systemgroup: Printer-Admins,lp

Dies produziert ein fehler in der cups error.log:

E [22/Oct/2012:13:41:38 +0200] Unknown SystemGroup "Printer-Admins,lp"
on line 609, ignoring!

Der Cups-Parameter akzeptiert zwar mehrere Gruppen, jedoch müssen die
mit leerschlägen separiert sein und nicht mit Komma."
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2013-05-14 21:00:14 CEST
Bitte in der cupsd.conf in univention-printserver korrigieren.
Comment 2 Liam Schwez univentionstaff 2013-05-21 14:06:37 CEST
A error message "Unknown SystemGroup "Printer-Admins,lp" on line 609, ignoring!" in "error.log" appears only if any of the groups in ucr variable "cups/systemgroup" does not exists.

But a correct separator for groups is a blank character. According to the cups.conf documentation.

Modified 'confd.conf' in package 'univention-printserver' at SystemGroup section. System groups are now separated by a blank character, not by a comma.

Imported and built the package 'univention-printserver' in buildsystem.
Modified changelog-3.1-2.tex at the section 'Printing Services'.
Comment 3 Moritz Muehlenhoff univentionstaff 2013-05-31 10:44:32 CEST
We will not ship a UCS 3.1-2 release; the next UCS release will be UCS 3.2.

As such, this bug is moved to the new target milestone.
Comment 4 Felix Botner univentionstaff 2013-06-17 16:09:45 CEST
debian/univention-printserver.postinst:
cups/systemgroup?"Printer-Admins lp"

-> more /etc/cups/cupsd.conf| grep -i systemgr
SystemGroup "Printer-Admins lp" 

This looks broken. The systemgroup list in cupsd.conf has to be space separated, but the ucr variable cups/systemgroup must remain a comma-separated list. 

Maybe we could also mention the correct separator (comma) in the description of the ucr variable cups/systemgroup.
Comment 5 Stefan Gohmann univentionstaff 2013-06-20 07:09:30 CEST
(In reply to Felix Botner from comment #4)
> debian/univention-printserver.postinst:
> cups/systemgroup?"Printer-Admins lp"
> 
> -> more /etc/cups/cupsd.conf| grep -i systemgr
> SystemGroup "Printer-Admins lp" 
> 
> This looks broken. The systemgroup list in cupsd.conf has to be space
> separated, but the ucr variable cups/systemgroup must remain a
> comma-separated list. 

Yes, see http://jenkins.knut.univention.de:8080/job/autotest/SambaVersion=s4,Systemrolle=master/lastCompletedBuild/testReport/%28root%29/51_samba4_36_printer/Creating_a_shared_printer_and_printing_from_smbclient/ for a test case. Currently the test fails.
Comment 6 Liam Schwez univentionstaff 2013-06-25 11:04:48 CEST
Modified 'cups/systemgroup' ucr variable in 'debian/univention-printserver.postinst'. 

- Set comma as separator.
- Extended with a reference in the description of the ucr variable 'cups/systemgroup' that it should be a comma-separated list.
Comment 7 Felix Botner univentionstaff 2013-06-26 10:26:17 CEST
OK
Comment 8 Stefan Gohmann univentionstaff 2013-11-19 06:43:23 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".