Univention Bugzilla – Bug 29263
call_joinscript sollte ausgeben welches Joinscript aufgerufen wird
Last modified: 2013-11-19 06:41:34 CET
call_joinscript sollte loggen welches Joinscript aufgerufen wird. Bei der Installation von Paketen auf dem DC-Master kann man sonst z.B. während eines Updates nicht erkennen ob Fehlermeldungen aus einem pre-/postinst kommen oder aus einem Joinscript.
Start und Ende des Joinskriptes sollte in der Ausgabe entsprechend "markiert" werden.
Marked start and finish of the executed joinscript at the console for a better tracing.
Changelogentry is missing.
Updated package "univention-lib": - made an debian/changelog entry - modified base.sh: function call_joinscript(): added console "start" and "finish" output of every executed joinscript for a better tracing. Imported package "univention-lib" into the build-system. Registered changes in changelog-3.1-2.tex. in section "base".
We will not ship a UCS 3.1-2 release; the next UCS release will be UCS 3.2. As such, this bug is moved to the new target milestone.
(1) call_joinscript() uses (4) space chars for indentation, usually tabs are used. This doesn't matter in shell script, but we should use tabs everywhere (2) ... local namejoinscript namejoinscript="$1" ... is unnecessary, just use echo "Calling joinscript $1 ..." echo "Calling joinscript $1 ..."
Modified function call_joinscript() in /shell/base.sh - replaced space chars in indentation by tabs - rid of local namejoinscript, namejoinscript="$1" Made an changelog entry and imported into buildsystem. (univention-lib_3.0.2-1)
(In reply to Liam Schwez from comment #7) > ... > (2) > ... > local namejoinscript > namejoinscript="$1" > ... (In reply to Liam Schwez from comment #7) > Modified function call_joinscript() in /shell/base.sh > - replaced space chars in indentation by tabs > - rid of local namejoinscript, namejoinscript="$1" > > Made an changelog entry and imported into buildsystem. > (univention-lib_3.0.2-1) Sorry, my fault, the "shift" statement deletes $1 so the "local namejoinscript ..." stuff is in fact required.
Updated package "univention-lib": - made an debian/changelog entry - modified base.sh: function call_joinscript(): added "local namejoinscript ..." stuff. Imported package "univention-lib" into the build-system.
OK - ucsmaster -> univention-install univention-squid ... Calling joinscript 79univention-squid.inst ... Object modified: cn=UNIVENTION_SQUID,cn=nagios,dc=fff,dc=ggg Joinscript 79univention-squid.inst finished with exitcode 0 ... OK - Changelog
UCS 3.2 has been released: http://docs.univention.de/release-notes-3.2-en.html http://docs.univention.de/release-notes-3.2-de.html If this error occurs again, please use "Clone This Bug".