Bug 30036 - univention-pam: Code cleanup
univention-pam: Code cleanup
Status: REOPENED
Product: UCS
Classification: Unclassified
Component: PAM
UCS 5.0
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS maintainers
:
Depends on:
Blocks: 34546
  Show dependency treegraph
 
Reported: 2013-01-16 08:19 CET by Philipp Hahn
Modified: 2020-09-20 10:22 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
hahn: Patch_Available+


Attachments
Cleanup (5.89 KB, patch)
2020-09-18 16:18 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-01-16 08:19:36 CET
See svn38319
Comment 1 Florian Best univentionstaff 2017-02-09 17:35:28 CET
???
Comment 2 Philipp Hahn univentionstaff 2017-02-10 09:48:25 CET
(In reply to Philipp Hahn from comment #0)
> See svn38319

Bug #29915: code cleanup
    string is deprecated.
    Simplify list modification.

was applied as ucs-3.1@38319 and reverted as ucs-3.1@38321. It still applies to UCS-4.2.
Comment 3 Philipp Hahn univentionstaff 2020-09-18 16:18:35 CEST
Created attachment 10499 [details]
Cleanup

Our UCR templates for /etc/pam.d/common-* are just crazy
At least conffiles/etc/pam.d/common-auth.d/50univention-pam_general uses "done", which immediately terminates the stack, which skips all following modules.

<https://linux.die.net/man/5/pam.d>

This is a left-over of Bug #52056