Bug 30796 - Automatic scrollbars in dijit/Dialog
Automatic scrollbars in dijit/Dialog
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.0
Other Linux
: P3 minor (vote)
: UCS 3.1-1-errata
Assigned To: Jascha Geerds
Dirk Wiesenthal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-15 13:52 CET by Alexander Kläser
Modified: 2013-06-13 14:36 CEST (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments
AutoScrollbar does not work (10.35 KB, image/png)
2013-05-22 14:35 CEST, Dirk Wiesenthal
Details
Sample dialog with scrollbars (111.00 KB, image/png)
2013-05-24 15:37 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2013-03-15 13:52:00 CET
Currently, the handling of scrollbars in the Dialog is not always correct. Nice would be if scrollbars were shown automatically for content that exceeds the dialog container.
Comment 1 Alexander Kläser univentionstaff 2013-03-15 13:52:57 CET
In the App Center, it should be already working correctly, however, for the list of installed packages, the scrollbars are not shown.
Comment 2 Jascha Geerds univentionstaff 2013-04-15 17:47:07 CEST
This bug has been fixed.

- ucs3.1-2 & changelog:
Package: univention-management-console-module-appcenter
Version: 2.0.143-1.121.201304151716

Package: univention-management-console-frontend
Version: 2.0.254-1.631.201304151720

-ucs3.1-1 & YAML:
Package: univention-management-console-module-appcenter
Version: 2.0.139-3.122.201304151732

Package: univention-management-console-frontend
Version: 2.0.244-9.632.201304151736
Comment 3 Jascha Geerds univentionstaff 2013-04-16 10:29:10 CEST
Package has been updated to make sure that the new appcenter is not installed without the new frontend.

-ucs3.1-1
Package: univention-management-console-module-appcenter
Version: 2.0.139-4.123.201304161021
Comment 4 Alexander Kläser univentionstaff 2013-04-16 13:33:18 CEST
(In reply to comment #3)
> Package has been updated to make sure that the new appcenter is not installed
> without the new frontend.
> 
> -ucs3.1-1
> Package: univention-management-console-module-appcenter
> Version: 2.0.139-4.123.201304161021

After discussing it, a better approach would be to remove the dependency on a particular version from the debian control file. In the App Center, the JavaScript code can evaluate tools.status("version") and if necessary set the width or not. In this way, the changes are more flexible.
Comment 5 Jascha Geerds univentionstaff 2013-04-16 14:38:44 CEST
(In reply to comment #4)
> After discussing it, a better approach would be to remove the dependency on a
> particular version from the debian control file. In the App Center, the
> JavaScript code can evaluate tools.status("version") and if necessary set the
> width or not. In this way, the changes are more flexible.

This has been fixed.

- ucs3.1-1:
Package: univention-management-console-module-appcenter
Version: 2.0.139-5.124.201304161436
Comment 6 Jascha Geerds univentionstaff 2013-04-16 17:24:25 CEST
(In reply to comment #5)
> (In reply to comment #4)
> > After discussing it, a better approach would be to remove the dependency on a
> > particular version from the debian control file. In the App Center, the
> > JavaScript code can evaluate tools.status("version") and if necessary set the
> > width or not. In this way, the changes are more flexible.
> 
> This has been fixed.
> 
> - ucs3.1-1:
> Package: univention-management-console-module-appcenter
> Version: 2.0.139-5.124.201304161436

Rather than a simple string comparison I have added a function called "compareVersion". The appcenter packages have been updated. Now both versions are identical.

- ucs3.1-2:
Package: univention-management-console-module-appcenter
Version: 2.0.144-1.126.201304161716

- ucs3.1-1:
Package: univention-management-console-module-appcenter
Version: 2.0.139-6.125.201304161708
Comment 7 Dirk Wiesenthal univentionstaff 2013-05-21 15:25:38 CEST
3.1-2: Fail: Comparing versions is not necessary here as the frontend is already patched when 3.1.2 is released.
Comment 8 Jascha Geerds univentionstaff 2013-05-21 15:57:44 CEST
(In reply to comment #7)
> 3.1-2: Fail: Comparing versions is not necessary here as the frontend is
> already patched when 3.1.2 is released.

This has been fixed in univention-management-console-module-appcenter (2.0.152-1)
Comment 9 Dirk Wiesenthal univentionstaff 2013-05-21 17:57:16 CEST
The App Center part is VERIFIED meaning: This bugfix does not break anything.

As for the frontend part itself: Does this mean that from now on every dijit/Dialog should be able to handle very long words and show a scrollbar automatically? I cannot confirm that this works.
Comment 10 Dirk Wiesenthal univentionstaff 2013-05-22 14:32:50 CEST
I do not know whether the bug is fixed as I do not which bug we are talking about. But as far as I can see nothing is broken. CSS was adapted to use max-width so this may be some kind of improvement. So I may call it VERIFIED.

As always, if this bug occurs again, feel free to clone this bug. But this time we mean it!
Comment 11 Dirk Wiesenthal univentionstaff 2013-05-22 14:35:56 CEST
Created attachment 5235 [details]
AutoScrollbar does not work

In 3.1-1 the many HALLO?s respect the max-width (good!) but there is no auto scrollbar although there is a big HALLO?HALLO?... (not good!?)

So is this bug really fixed? Was this the scope of this bug?
Comment 12 Moritz Muehlenhoff univentionstaff 2013-05-22 16:10:05 CEST
http://errata.univention.de/ucs/3.1/102.html
Comment 13 Alexander Kläser univentionstaff 2013-05-24 15:37:55 CEST
Created attachment 5238 [details]
Sample dialog with scrollbars

The behaviour can be tested with the following JavaScript-Code:

> var s = ''; for (var i = 0; i < 2000; ++i) s += i + ' '; require('umc/dialog').alert(s)

On an updated system, the scrollbars work fine.

Note, the "Hallo?Hallo?Hallo?..." line does not contain white spaces, horizontal scrollbars are not shown automatically, this bug was supposed to handle vertical scrollbars which seem to work as expected (see screenshot).
Comment 14 Alexander Kläser univentionstaff 2013-06-08 16:34:42 CEST
The bug has not been published yet as erratum AFAIS → VERIFIED
Comment 15 Janek Walkenhorst univentionstaff 2013-06-13 14:36:53 CEST
http://errata.univention.de/ucs/3.1/123.html