Univention Bugzilla – Bug 30822
[Piwik] Errors with enabled Ghostery plugin in FF
Last modified: 2016-04-13 14:57:08 CEST
With enabled Ghostery plugin, Piwik is blocked in FF. This results in some module not being loaded as the error that is triggered while loading piwik.js seems to confuse the normal module loading process. The error that Firefox throws is a script error.
*** Bug 39182 has been marked as a duplicate of this bug. ***
@Eduard: Could you have a look at this issue? Adding an dedicated handling of a module load error for piwik.js is probably the way to go (in app.js in package univention-management-console-frontend).
Created attachment 7348 [details] Exclude piwik errors from UMC dialogs The attached diff contains a change which excludes piwik errors from being shown in UMC dialog boxes.
Comment on attachment 7348 [details] Exclude piwik errors from UMC dialogs This looks good but might fail if the exception doesn't have attributes like info. Maybe better surround this by try-catch?: >Index: management/univention-management-console-frontend/umc/app.js >=================================================================== >--- management/univention-management-console-frontend/umc/app.js (Revision 65939) >+++ management/univention-management-console-frontend/umc/app.js (Arbeitskopie) >@@ -1210,7 +1210,7 @@ > _loadJavascriptModules: function(modules) { > // register error handler > require.on('error', function(err) { >- if (err.message == 'scriptError') { var isPiwikModule = false; try { isPiwikModule = err.info[0].split("/").pop(-1) == 'piwik.js'; } catch (err) {} + if (err.message == 'scriptError' && !isPiwikModule) { > dialog.warn(_('Could not load module "%s".', err.info[0])); > console.log('scriptError:', err); > }
(In reply to Florian Best from comment #4) > Comment on attachment 7348 [details] > Exclude piwik errors from UMC dialogs > > This looks good but might fail if the exception doesn't have attributes like > info. Maybe better surround this by try-catch?: Good idea, however, "err.info[0]" is accessed via dialog.warn() anyway, so that it could eventually break there, as well.
AFAIK, the error also pops up when starting a UCS appliance that has no internet access. Please check whether your patch also applies to this problem.
UCS-4.1-1: r68224: Errors concerning Piwik are now suppressed. r68225: yaml file. Package: univention-management-console-frontend Version: 5.0.63-30.1220.201603211732
Changes: OK YAML file: OK → VERIFIED
<http://errata.software-univention.de/ucs/4.1/150.html>