Bug 30974 - Cleanup for udm-cli-server and udm-cli-client
Cleanup for udm-cli-server and udm-cli-client
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UDM - CLI
UCS 3.1
Other Linux
: P5 enhancement (vote)
: UCS 3.2
Assigned To: Philipp Hahn
Lukas Walter
: interim-2
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-04 11:47 CEST by Philipp Hahn
Modified: 2013-11-19 06:42 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments
Cleanup for cli-server and cli-client (20.74 KB, patch)
2013-04-04 11:47 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-04-04 11:47:59 CEST
Created attachment 5157 [details]
Cleanup for cli-server and cli-client

Relative to svn39811

$ diffstat univention-directory-manager-modules/cleanup.diff
 univention-cli-client |  225 ++++++++++++++++++++-----------------
 univention-cli-server |  301
+++++++++++++++++++++-----------------------------
 2 files changed, 252 insertions(+), 274 deletions(-)

Mostly code cleanup to help future readers to understand the code.
Remove unused imports
Use symbolic names instead of magic constants (SIGCONT, debug.FLUSH)
Use True and False instead of 1 and 0
Catch specific exception
Fix lots of PyLint issues
Print errors to stderr (Bug #4498)

$ git diff --ignore-all-space . | diffstat 
 univention-cli-client |  179 ++++++++++++++++++++-----------------
 univention-cli-server |  241
++++++++++++++++++++------------------------------
 2 files changed, 199 insertions(+), 221 deletions(-)


Please also apply Bug #29074 !
Comment 1 Philipp Hahn univentionstaff 2013-08-26 14:47:25 CEST
r43453 | Bug #29074,Bug #30974: udm-cli revamp
univention-directory-manager-modules_9.0.17-1.1039.201308261445

ChangeLog:
The code of the command line programs has been modernized.
An error message regarding an existing directory has been corrected.
Comment 2 Lukas Walter univentionstaff 2013-09-17 13:54:26 CEST
ok: still working after cleanup
ok: changelog entry for ucs 3.2
Comment 3 Stefan Gohmann univentionstaff 2013-11-19 06:42:14 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".