Bug 31141 - renewing of computerroom settings doesn't take effect: Invalid SMB process definition
renewing of computerroom settings doesn't take effect: Invalid SMB process de...
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 3.1
Other Linux
: P5 normal (vote)
: UCS@school 3.1 R2
Assigned To: Arvid Requate
Florian Best
: interim-1
Depends on:
Blocks: 31202
  Show dependency treegraph
 
Reported: 2013-04-23 13:46 CEST by Florian Best
Modified: 2013-06-07 21:40 CEST (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2013-04-23 13:46:52 CEST
Currently restricting printer access via computerroom module does not work.

(The code in backend parses the output of smbstatus which fails (it has a new format probably)).

23.04.13 13:34:49.645  PARSER      ( ERROR   ) : Invalid SMB process definition
23.04.13 13:34:49.645  PARSER      ( INFO    ) : 
Samba version 4.0.3
PID     Username      Group         Machine                        
-------------------------------------------------------------------
12756     Administrator  Domain Admins  10.200.27.240 (ipv4:10.200.27.240:1182)
11072     lehrer1       Domain Users fooschool  10.200.27.5  (ipv4:10.200.27.5:60030)

Service      pid     machine       Connected at
-------------------------------------------------------
IPC$         12756   10.200.27.240  Tue Apr 23 12:23:46 2013
IPC$         11072   10.200.27.5   Tue Apr 23 12:10:32 2013
lehrer1      11072   10.200.27.5   Tue Apr 23 12:05:57 2013

Locked files:
Pid          Uid        DenyMode   Access      R/W        Oplock           SharePath   Name   Time
--------------------------------------------------------------------------------------------------
11072        2014       DENY_NONE  0x100080    RDONLY     NONE             /home/lehrer1   .   Tue Apr 23 12:06:40 2013

=====
Wrong component? This should be a bug against ucsschool.lib
Comment 1 Florian Best univentionstaff 2013-04-23 15:53:14 CEST
The IP-Adress does not match anymore: …"\((?P<ipAddress>[0-9a-fA-F.:]+)\)$"

IP: "(ipv4:10.200.27.240:1182)"
Comment 2 Florian Best univentionstaff 2013-04-23 15:58:51 CEST
(In reply to comment #0)
> Currently restricting printer access via computerroom module does not work.
s//The SMB connection can not be killed due to the errorneous parsing/

This has the effect, that the new settings aren't immediately active for computers which already have a SMB connection.
Comment 3 Arvid Requate univentionstaff 2013-04-24 20:07:03 CEST
The regular expression is now extended to match "ipv4:" and "ipv6:" prefixes as well as the old prefix-less output. The SMB_Process class was extended to offer the matched addresses as properties "ipaddress", "ipv4address" and "ipv6address" respectively, currently these are not used anywhere.

Changelog updated: changelog-ucsschool-3.1R2.tex
Comment 4 Florian Best univentionstaff 2013-04-26 09:30:47 CEST
(In reply to comment #3)
> The regular expression is now extended to match "ipv4:" and "ipv6:" prefixes as
> well as the old prefix-less output. The SMB_Process class was extended to offer
> the matched addresses as properties "ipaddress", "ipv4address" and
> "ipv6address" respectively, currently these are not used anywhere.
Ok, the computerroom settings can be modified again without resetting connections by hand.

code-review: OK

> Changelog updated: changelog-ucsschool-3.1R2.tex
Ok, i added \ucsName{}
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2013-06-07 21:40:20 CEST
UCS@school 3.1 R2 has been released:
http://download.univention.de/doc/release-notes-ucsschool-3.1-rev2.pdf

If this error occurs again, please use "Clone This Bug".