Bug 31192 - System info upload uses wrong url
System info upload uses wrong url
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Sysinfo
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 4.0-0-errata
Assigned To: Florian Best
Drees Dormann
:
Depends on:
Blocks: 31199
  Show dependency treegraph
 
Reported: 2013-04-25 14:17 CEST by Janis Meybohm
Modified: 2014-12-19 11:48 CET (History)
5 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janis Meybohm univentionstaff 2013-04-25 14:17:22 CEST
version/erratalevel: 0
version/patchlevel: 1
version/releasename: Findorff
version/security-patchlevel: <empty>
version/version: 3.1

If I click through the system info upload and choose "Upload" the UMC shows a module process error, error message of the server was: None

Creation of the archive in general seems to work as I'm able to download/extract it when using "Mail" mode.


==> /var/log/univention/management-console-web-server.log <==
25.04.13 14:10:10.570  PARSER      ( INFO    ) : UMCP RESPONSE 136689181038822-62 parsed successfully
25.04.13 14:10:10.571  PROTOCOL    ( INFO    ) : Received UMCP RESPONSE 136689181038822-62
25.04.13 14:10:10.571  MAIN        ( INFO    ) : SessionClient(0x23e1dd0): got response(136689181038822-62): status=200 queue=0x23f2f38
25.04.13 14:10:10.571  MAIN        ( INFO    ) : CPCommand (192.168.0.112:50294) got response(0x23ee410) from queue(0x23f2f38): status=200 (sessionid="b57b75a1-7d63-4707-81d2-719d69c200da")
25.04.13 14:10:17.232  MAIN        ( INFO    ) : CPCommand (10.205.1.58:50295) got new request
25.04.13 14:10:17.232  MAIN        ( INFO    ) : CPCommand (10.205.1.58:50295) found sessionid
25.04.13 14:10:17.232  MAIN        ( INFO    ) : CPCommand (10.205.1.58:50295) sessionid="15dee6db-083e-43d5-96c9-8e3b60fd21ce"
25.04.13 14:10:17.232  MAIN        ( INFO    ) : CPCommand (10.205.1.58:50295) pushed request(0x23ee190) to queue(0x2352a28) - waiting for response (sessionid="15dee6db-083e-43d5-96c9-8e3b60fd21ce")
25.04.13 14:10:17.304  MAIN        ( INFO    ) : UMCP_Dispatcher: check_queue: new request: 0x23ee650
25.04.13 14:10:17.304  MAIN        ( INFO    ) : UMCP_Dispatcher: check_queue: normal request
25.04.13 14:10:17.304  MAIN        ( INFO    ) : SessionClient(0x234e8d0): sending request(136689181723260-63)
25.04.13 14:10:17.304  PROTOCOL    ( INFO    ) : Sending UMCP COMMAND REQUEST 136689181723260-63

==> /var/log/univention/management-console-server.log <==
25.04.13 14:10:17.305  PARSER      ( INFO    ) : UMCP REQUEST 136689181723260-63 parsed successfully
25.04.13 14:10:17.305  MAIN        ( INFO    ) : Incoming request of type COMMAND
25.04.13 14:10:17.305  RESOURCES   ( INFO    ) : Searching for module providing command sysinfo/upload
25.04.13 14:10:17.305  RESOURCES   ( INFO    ) : Found module sysinfo
25.04.13 14:10:17.306  MAIN        ( INFO    ) : Passing new request to running module sysinfo
25.04.13 14:10:17.306  PROTOCOL    ( INFO    ) : Sending UMCP COMMAND REQUEST 136689181723260-63
25.04.13 14:10:17.497  PARSER      ( INFO    ) : UMCP RESPONSE 136689181723260-63 parsed successfully
25.04.13 14:10:17.497  PROTOCOL    ( INFO    ) : Received UMCP RESPONSE 136689181723260-63

==> /var/log/univention/management-console-web-server.log <==
25.04.13 14:10:17.497  PARSER      ( INFO    ) : UMCP RESPONSE 136689181723260-63 parsed successfully
25.04.13 14:10:17.497  PROTOCOL    ( INFO    ) : Received UMCP RESPONSE 136689181723260-63
25.04.13 14:10:17.497  MAIN        ( INFO    ) : SessionClient(0x234e8d0): got response(136689181723260-63): status=590 queue=0x2352a28
25.04.13 14:10:17.497  MAIN        ( INFO    ) : CPCommand (10.205.1.58:50295) got response(0x23ee990) from queue(0x2352a28): status=590 (sessionid="15dee6db-083e-43d5-96c9-8e3b60fd21ce")
25.04.13 14:10:17.497  MAIN        ( PROCESS ) : CPCommand (10.205.1.58:50295) response status code: 590
25.04.13 14:10:17.497  MAIN        ( PROCESS ) : CPCommand (10.205.1.58:50295) response message: None
25.04.13 14:10:17.498  MAIN        ( PROCESS ) : CPCommand (10.205.1.58:50295) response result: Non
Comment 1 Dirk Wiesenthal univentionstaff 2013-04-25 21:17:58 CEST
This is most probably a server-side error (UCS 2.4 cannot upload either). The cgi.FieldStorage() is completely empty and no file is found. The server sends the "correct" (yet very uncomfortable) error message: ERROR: wrong file type or file to big

This message is suppressed by the client which may be considered a bug. And the whole error handling is not very graceful. But in the end it is a problem of forge.univention.de

This is the best I can come up with. It is just a guess: http://stackoverflow.com/questions/2781493/cgi-fieldstorage-always-empty-never-returns-posted-form-data
Did we add new apache services? Do we use mod_python since February?

By the way:
max_size = configRegistry.get( 'umc/sysinfo/upload/size', '2000000' )
...
size > max_size
  will always be true because an int is compared to a string
Comment 2 Janis Meybohm univentionstaff 2013-04-26 09:50:18 CEST
The real "bug" probably is that the "wrong" domain is used for uploading:

- FALLBACK_UPLOAD_URL = 'https://forge.univention.de/cgi-bin/system-info-upload.py'
+ FALLBACK_UPLOAD_URL = 'https://forge.univention.org/cgi-bin/system-info-upload.py'


https://forge.univention.de is then redirected to https://forge.univention.org on server side which cases the CGI to break. I'm going to add an exception here on the server side but we should change the domain in the code.


Besides: No need for errata anymore!
Comment 3 Dirk Wiesenthal univentionstaff 2013-04-26 10:15:25 CEST
The wrong domain is also used by UCS 2.4. I suppose we have to support both domains for a while.
Comment 4 Florian Best univentionstaff 2014-12-18 13:46:41 CET
Replaced forge.univention.de by forge.univention.org during working on sysinfo.

Fix: svn r56967
YAML: 2014-12-18-univention-system-info.yaml
Comment 5 Drees Dormann univentionstaff 2014-12-18 15:12:35 CET
upload is working 
YAML ok
Comment 6 Janek Walkenhorst univentionstaff 2014-12-19 11:48:03 CET
http://errata.univention.de/ucs/4.0/11.html