Bug 31285 - (Un-)quoting bug: UMC error message per email
(Un-)quoting bug: UMC error message per email
Status: RESOLVED WORKSFORME
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.2
All Linux
: P5 normal (vote)
: UCS 3.2-x
Assigned To: UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-06 10:55 CEST by Philipp Hahn
Modified: 2014-11-03 23:59 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments
patch (552 bytes, patch)
2014-01-22 10:03 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-05-06 10:55:04 CEST
If UMC catches a traceback, a dialog is shown to provide feedback.
This includes a link to generate an email.
In that email quotation marks (") are not escaped properly, but printed as HTML entity names (")

<a href="mailto:feedback%40univention.de?body=Bitte%20nehmen%20Sie%20sich%20einen%20Augenblick%20Zeit%2C%20um%20die%20folgenden%20Informationen%20bereitzustellen%3A%0A%0A1)%20Schritte%2C%20um%20den%20Fehler%20zu%20reproduzieren%0A2)%20erwartetes%20Ergebnis%0A3)%20beobachtetes%20Ergebnis%0A%0A----------%0A%0A%20%20File%20%26quot%3B%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Fnotifier%2Fthreads.py%26quot%3B%2C%20line%2082%2C%20in%20_run%0A%20%20%20%20tmp%20%3D%20self._function()%0A%20%20File%20%26quot%3B%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Fnotifier%2F__init__.py%26quot%3B%2C%20line%20104%2C%20in%20__call__%0A%20%20%20%20return%20self._function(%20*tmp%2C%20**self._kwargs%20)%0A%20%20File%20%26quot%3B%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Funivention%2Fmanagement%2Fconsole%2Fmodules%2Fudm%2F__init__.py%26quot%3B%2C%20line%20965%2C%20in%20_thread%0A%20%20%20%20obj%20%3D%20module.get(%20object_dn%20)%0A%20%20File%20%26quot%3B%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Funivention%2Fmanagement%2Fconsole%2Fmodules%2Fudm%2Fudm_ldap.py%26quot%3B%2C%20line%20155%2C%20in%20wrapper_func%0A%20%20%20%20ret%20%3D%20func(%20*args%2C%20**kwargs%20)%0A%20%20File%20%26quot%3B%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Funivention%2Fmanagement%2Fconsole%2Fmodules%2Fudm%2Fudm_ldap.py%26quot%3B%2C%20line%20459%2C%20in%20get%0A%20%20%20%20raise%20UDM_Error(%20get_exception_msg(%20e%20)%20)%0A%0AUDM_Error%3A%20Die%20angegebenen%20Informationen%20reichen%20nicht%20aus.%20superordinate%20object%20not%20present%0A%0A%0A----------%0A%0Aunivention-management-console-frontend%202.0.244-1.615.201303221534&amp;subject=%5BUMC-Feedback%5D%20Traceback">Feedback per E-Mail senden</a>

univention-management-console-frontend/umc/tools.js:603
  message.replace(/<br *\/?>/g, "\n"),

this is not sufficient, there are more things to unquote ...
Comment 1 Florian Best univentionstaff 2014-01-22 10:03:09 CET
Created attachment 5740 [details]
patch
Comment 2 Florian Best univentionstaff 2014-11-03 23:59:43 CET
This was fixed in UCS4.0.