Bug 31737 - never ever show installation button if app is already installed
never ever show installation button if app is already installed
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Dirk Wiesenthal
Florian Best
: interim-2
Depends on: 31891
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-13 15:23 CEST by Felix Botner
Modified: 2013-11-19 06:44 CET (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2013-06-13 15:23:49 CEST
Installed an app without key id license (app appliance). After system-setup-boot i open the UMC app center and my app is installed (green checkmark). But when i open the app, there is a button for the installation?

Maybe this has something to do with the missing key id, but if an app is installed, we should never display the installation button.
Comment 1 Alexander Kläser univentionstaff 2013-06-14 18:39:26 CEST
AFAIK, the installation status is checked via the installed packages and probably the buttons are displayed according to the installed repository components.
Comment 2 Dirk Wiesenthal univentionstaff 2013-06-18 18:47:53 CEST
(In reply to Alexander Kläser from comment #1)
> AFAIK, the installation status is checked via the installed packages and
> probably the buttons are displayed according to the installed repository
> components.

The green checkmark shows that the app is identified as installed. The problem is that it was not allowed to be installed and the (frontend of the) App Center does not handle this case.

The following lines in AppCenterPage.js are responsible for this bug:

if (!app.allows_using && this._udm_accessible) {
  var label = app.can_update ? _('Upgrade') : _('Install');
  ...

One would have to extend the first line.
Comment 3 Dirk Wiesenthal univentionstaff 2013-06-18 22:34:29 CEST
(In reply to Felix Botner from comment #0)
> Maybe this has something to do with the missing key id, but if an app is
> installed, we should never display the installation button.

Just to make clear: Yes this is because the Key ID is missing. The correct label would be "Request" or something like that. But we relabel that button to Install or Upgrade...
Comment 4 Dirk Wiesenthal univentionstaff 2013-09-05 14:14:50 CEST
Fixed since
  univention-management-console-module-appcenter (3.0.21-1)

"Install" is shown if (and only if) !app.is_installed
Comment 5 Florian Best univentionstaff 2013-09-19 13:41:03 CEST
fix: OK
in no case the installation button is showed if the app is already installed
Changelog OK
Comment 6 Stefan Gohmann univentionstaff 2013-11-19 06:44:09 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".