Bug 32035 - computerroom/update does not send "isTeacher" when another user logs in
computerroom/update does not send "isTeacher" when another user logs in
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 3.1 R2
Other Linux
: P5 normal (vote)
: UCS@school 3.1 R2 Errata
Assigned To: Florian Best
Sönke Schwardt-Krummrich
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-22 15:46 CEST by Florian Best
Modified: 2013-10-07 20:17 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
patch (3.14 KB, patch)
2013-07-23 11:08 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2013-07-22 15:46:51 CEST
If a teacher logs out (from client) and a student logs in the information in the frontend about the user is not actualised. The backend only sends the new username, not the information about the "isTeacher" flag.
→ All commands which are (un)available for teachers are then (un)available for the student.
Comment 1 Florian Best univentionstaff 2013-07-23 11:08:27 CEST
Created attachment 5335 [details]
patch

The attached patch makes it more robust: The whole computer representation will be send if the computer changes. This will fix it.
I could not find the reason why the "teacher" state was not updated. On user changes the "_userInfo" function updates it, the only thing i could imagine is that it needs to be updated on every _stateChanged() due to lost of connection.
Comment 2 Florian Best univentionstaff 2013-07-23 11:09:10 CEST
decided to not fix it now.
Comment 3 Florian Best univentionstaff 2013-09-06 16:03:32 CEST
ucs-school-umc-computerroom (3.0.14-1)

Patch applied.
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2013-10-02 15:55:21 CEST
OK: 3.1 code diff
FIXED: 3.1 changelog
OK: 3.1 package version
OK: 3.1 test
OK: 3.1 package in repo

OK: 3.2 code diff
FIXED: 3.2 changelog
FIXED: 3.2 package version
OK: 3.2 test

* Changelog entry in 3.1 has been fixed.
* Changelog entry in 3.2 was missing. Copied it from 3.1.
* Bumped version 3.2 package - package had been copied to 3.2 after fixing the bug.

→ VERIFIED
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2013-10-07 20:17:54 CEST
UCS@school 3.1 R2-2 has been released:
http://download.univention.de/doc/release-notes-ucsschool-3.1-rev2-2.pdf

If this error occurs again, please use "Clone This Bug".