Univention Bugzilla – Bug 32091
UVMM code cleanup (bugs in python scripts)
Last modified: 2013-11-19 06:44:24 CET
univention-virtual-machine-manager-daemon Errors: ./uvmmd-ldap.py:65: undefined name 'uvmm_p' ./uvmmd-ldap.py:68: undefined name 'uvmm_c' ./uvmmd-ldap.py:72: undefined name 'uvmm_c' ./test/urlparser.py:83: undefined name 'urlparse' ./test/urlparser.py:84: undefined name 'urlparse' ./src/univention/uvmm/client.py:285: undefined name 'Response_ERROR' ./src/univention/uvmm/helpers.py:33: undefined name 'match_self' in __all__ ./src/univention/uvmm/helpers.py:33: undefined name 'uri_netloc' in __all__ Some other warnings: ./scripts-dev/check-vms.py:21: redefinition of unused 'ET' from line 19 ./umc/python/uvmm/profiles.py:33: 'univention' imported but unused ./test/urlparser.py:93: 'rlcompleter' imported but unused ./src/univention/uvmm/uvmm_ldap.py:39: redefinition of unused 'pickle' from line 37 ./src/univention/uvmm/uvmm_ldap.py:43: 'ldapurl' imported but unused ./src/univention/uvmm/unix.py:43: 'TranslatableException' imported but unused ./src/univention/uvmm/protocol.py:36: redefinition of unused 'StringIO' from line 34 ./src/univention/uvmm/protocol.py:40: redefinition of unused 'pickle' from line 38 ./src/univention/uvmm/node.py:44: redefinition of unused 'ldap_annotation' from line 44 ./src/univention/uvmm/node.py:63: redefinition of unused 'ET' from line 61 ./src/univention/uvmm/node.py:67: redefinition of unused 'pickle' from line 65 ./src/univention/uvmm/storage.py:39: 'getDOMImplementation' imported but unused ./src/univention/uvmm/helpers.py:121: 'time' imported but unused ./src/univention/uvmm/eventloop.py:220: local variable 'data' is assigned to but never used ./scripts-dev/check-vms.py:583: local variable '_vol' is assigned to but never used ./src/univention/uvmm/node.py:1528: local variable 'ret' is assigned to but never used
(In reply to Florian Best from comment #0) > Errors: > ./uvmmd-ldap.py:65: undefined name 'uvmm_p' > ./uvmmd-ldap.py:68: undefined name 'uvmm_c' > ./uvmmd-ldap.py:72: undefined name 'uvmm_c' Ignored: This is dead code and never reached because of the "continue" above those lines. The code remains until the import mechanism of the Listener works correctly. > ./test/urlparser.py:83: undefined name 'urlparse' > ./test/urlparser.py:84: undefined name 'urlparse' Ignored: pylint is not perfect, especially for dynamically defines things, which would pylint require the code to be executed. It will not do this by design. See <http://www.logilab.org/blogentry/78354> for a solution. > ./src/univention/uvmm/client.py:285: undefined name 'Response_ERROR' Fixed: Missing prefix "protocol." > ./src/univention/uvmm/helpers.py:33: undefined name 'match_self' in __all__ > ./src/univention/uvmm/helpers.py:33: undefined name 'uri_netloc' in __all__ > ./src/univention/uvmm/uvmm_ldap.py:43: 'ldapurl' imported but unused > ./svi:43: 'TranslatableException' imported but unused > ./src/univention/uvmm/storage.py:39: 'getDOMImplementation' imported but > unused Removed: no longer used/defined. > Some other warnings: > ./scripts-dev/check-vms.py:21: redefinition of unused 'ET' from line 19 > ./src/univention/uvmm/uvmm_ldap.py:39: redefinition of unused 'pickle' from line 37 > ./src/univention/uvmm/protocol.py:36: redefinition of unused 'StringIO' from line 34 > ./src/univention/uvmm/protocol.py:40: redefinition of unused 'pickle' from line 38 > ./src/univention/uvmm/node.py:63: redefinition of unused 'ET' from line 61 > ./src/univention/uvmm/node.py:67: redefinition of unused 'pickle' from line 65 Ignored: Constructs used for backward compatibility > ./umc/python/uvmm/profiles.py:33: 'univention' imported but unused False positive: Loading the module triggers some actions like detecting all available UDM modules. > ./test/urlparser.py:93: 'rlcompleter' imported but unused Ignored: Needed for interactive debugging: python -i test/urlparser.py > ./src/univention/uvmm/node.py:44: redefinition of unused 'ldap_annotation' from line 44 Removed: Double included > ./src/univention/uvmm/helpers.py:121: 'time' imported but unused False positive: used in DocTest code. > ./src/univention/uvmm/eventloop.py:220: local variable 'data' is assigned to but never used Ignored: foreign code, DO NOT TOUCH (Bug #31371) > ./src/univention/uvmm/node.py:1528: local variable 'ret' is assigned to but never used Fixed: variable removed > ./scripts-dev/check-vms.py:583: local variable '_vol' is assigned to but never used Ignored: the '_' prefix is a common idiom used to indicate unused variables by design. That's only an internal script for development. svn42809 Other issues for a quick bQA: svn42780: UVMM remove dead code and data svn42778: UVMM Fix translation messages svn42808: UVMM/js dojo adjustments svn42807: UVMM DriveWizard: pre-select 'disk' ChangeLog: Some code issues in UVMM have been fixed univention-virtual-machine-manager-daemon_3.0.6-2.459.201307261228
The referenced dead code has been removed, changelog exists.
UCS 3.2 has been released: http://docs.univention.de/release-notes-3.2-en.html http://docs.univention.de/release-notes-3.2-de.html If this error occurs again, please use "Clone This Bug".