Bug 32136 - UMC domain join module throws traceback with UCC Image join scripts
UMC domain join module throws traceback with UCC Image join scripts
Status: CLOSED FIXED
Product: Z_Univention Corporate Client (UCC)
Classification: Unclassified
Component: Image management
unspecified
Other Linux
: P5 normal
: UCC 1.0-errata
Assigned To: Erik Damrose
Moritz Muehlenhoff
:
Depends on: 32107
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-31 11:35 CEST by Alexander Kläser
Modified: 2014-01-17 14:24 CET (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2013-07-31 11:35:42 CEST
From Bug 32107, comment 3:
> The problem is the name of the join script ending on .img. The join module
> reads in all join scripts ending on .inst or .uinst. The exact regexp is:
> 
>   ^(?P<script>(?P<prio>\d+)(?P<name>.+))\.(inst|uinst)$
> 
> Now the UCC join script has already been executed and its name appears in
> /var/univention-join/status. As the file name does not appear in the list of
> the afore read file names, a key error is thrown.
> 
> (a) This is a problem of the UMC join module as it should not throw a
> traceback.
> 
> (b) Probably the name of the UCC join script should be adjusted, otherwise
> it will not be displayed in the UMC join module.

(b) applies to UCC.


+++ This bug was initially created as a clone of Bug #32107 +++

Seen on UCS 3.1-1 Errata130, seen on DC Slave

The UMC module for calling join scripts throws a traceback if a join script from a customer generated UCC image lays under /usr/lib/univention-install (as recommended by UCC documentation). Calling the script with "univention-run-joinscripts" works fine but doesn't resolv the traceback in the UMC module -- the UMC module can't be used as long as the join script isn't removed.

------------------------------------------------------------------------
Die Ausführung des Kommandos join/scripts/query ist fehlgeschlagen:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/__init__.py", line 204, in execute
    func( request )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py", line 282, in _response
    result = _multi_response(self, request)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py", line 384, in _response
    for res in function(self, iterator, *nones):
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py", line 266, in _fake_func
    yield function(self, *args)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/join/__init__.py", line 288, in query
    files[name]['configured'] = False
KeyError: '/usr/lib/univention-install/ucc-1.0-rev2-thinclient-image-lts-quantal.img'
------------------------------------------------------------------------
Comment 1 Erik Damrose univentionstaff 2014-01-07 12:16:50 CET
The joinscripts for ucc images end on .inst, but they do not by default contain a sequence number (_95_ucc-...inst), which is only added by ucc-image-download.

The problem at Bug 32107 is that executable files ending on (.inst|.uinst) without a sequencenumber at the start of the filename cause the umc module to throw a traceback.

This bug will fix the ucc-image* tools to always write joinscripts with a sequencenumber.
Comment 2 Erik Damrose univentionstaff 2014-01-07 14:48:28 CET
Fixed in ucc-image-toolkit 1.0.7-5.146.201401071427:

* Improved image toolkit support for image joinscripts with sequence
numbers. Image joinscripts created since this version will be created
with a 95[filename] prefix. (Bug #32136)
* Updated example files for rev3 images

QA: Tests should be done with a new rev3 image build (which should contain the 95[...].inst joinscript) and old images (the joinscript name is changed after the download).

In particular, the changed tools must be tested with old and new joinscript files:
ucc-image, ucc-image-download, ucc-image-remove

After QA is done, the UCC documentation must be updated with the new joinscript name format.

We need to decide where the ucc-integration changelog should be maintained.
Comment 3 Moritz Muehlenhoff univentionstaff 2014-01-15 14:54:08 CET
The naming scheme has been corrected.
Comment 4 Moritz Muehlenhoff univentionstaff 2014-01-17 14:24:29 CET
Released through the App Center