Univention Bugzilla – Bug 32332
Change "Assign teacher to class" workflow
Last modified: 2015-05-11 19:24:56 CEST
A customer reported that the workflow of assigning a teacher to classes seems inconvenient to him, when teachers need/want to be assigned to several classes at once. Right now, the workflow is as follows: - teacher searches for one of the classes he wants to assign him/herself to - teacher opens the first class and adds him/herself - teacher repeats these steps for every class The following workflow would be preferred: - teacher selects his user - teacher selects all classes via checkboxes he wants to assign him/herself to
Another customer reported this issue.
This was a feature request of all attendees of a UCS@school workshop today. The current workflow is considered counterintuitive: - Select one (!) class (multi edit does not work) - Add a teacher to this single class - save - repeat What is actually needed, is the other way round: - Select a teacher - Assign this teacher to (multiple) classes At least, multi edit for the current workflow should be possible. Right now, the "Edit" button is deactivated, if I select more than one class at once.
Created attachment 6806 [details] no multi edit possible when assigning teachers to classes (not sure where the mixture of german/english in the screenshot comes from, this should probably be part of another bug)
As discussed directly with Florian, we should try to show 2 grids on top of each other: one for class groups and one for teachers. So the user is able to assign - teachers to a class or - classes to a teacher. I just noted that within the module is no hint, what kind of functionality the module provides and what the user has to do next. Maybe a small helptext can be added to the left column. > (not sure where the mixture of german/english in the screenshot comes from, > this should probably be part of another bug) Please also have a look at the translations.
(In reply to Sönke Schwardt-Krummrich from comment #4) > As discussed directly with Florian, we should try to show 2 grids on top of > each other: one for class groups and one for teachers. > So the user is able to assign > - teachers to a class or > - classes to a teacher. I am not convinced that two visible grids would be a good idea. I could think of leaving one single grid with a button to switch between the two modi, e.g., with a label as '[ teacher → classes ]' and once you press the label changes accordingly.
As a base I rewrote the module to use the python ucs-school-lib model classes. svn r60034, svn r60035
Ok, this have been implemented as another flavor. Various text changes have been done in the module. The whole module (all 4 flavors) have to be QAed. ucs-school-umc-groups (4.0.0-3): r60186 | Bug #32332: make removal of teachers possible r60154 | Bug #32332: add flavor to assign classes to a single teacher r60035 | Bug #32332: rewrite module to use ucsschool.lib.models ucs-school-lib (7.0.4-1): r60185 | Bug #32332: fix workgroup detection r60034 | Bug #32332: add model abstraction for WorkGroups
Another bug in ucsschool.lib has been fixed: References like SchoolClass(...).users were lists. Doing user.remove(dn) did not have any effect when modify()ing. r60195 | Bug #32332: fix changing of values which were e.g. lists due to caching
If a workgroup already exists no error message was shown due to no error handling in the models class. Error handling has been added. ucs-school-lib (7.0.5-1): r60221 | Bug #32332: fix returncode of SchoolClass create ucs-school-umc-groups (4.0.0-4): r60222 | Bug #32332: Add error message if group already exists The schoolwizards module contained an error which had to be fixed for the functionality to work, too. It did wrongly create DN's like "$school-$name" which was too late so that obj.exists(lo) always returned false. ucs-school-umc-wizards (6.0.2-1): r60220 | Bug #32332: fix creation of school DNs when adding class objects
"Legt die Zeichenketten die in dem angezeigten Namen gesucht werden soll fest" → "Nach dieser Zeichenkette soll in den angezeigten Namen gesucht werden" Error message if all classes are removed in Module "Zuweisen von Klassen zu einem Lehrer": Webfrontend-Fehler: Die angegebenen Argumente für die UMCP-Modul-Methode sind nicht zulässig oder fehlen. Fehlernachricht des Servers: Eine Option für put hat den falschen Typ: 1 Fehler aufgetreten "Klassen der angegebenen Schule" → "Liste der Klassen, in denen der ausgewählte Lehrer Mitglied ist" Module "Zuweisen von Klassen zu einem Lehrer": the grid shows all group names with OU prefix; every other dialog skips the prefix.
All points addressed in: Package: ucs-school-umc-groups Version: 4.0.0-7.69.201504291742
> "Legt die Zeichenketten die in dem angezeigten Namen gesucht werden soll > fest" > → "Nach dieser Zeichenkette soll in den angezeigten Namen gesucht werden" → OK > Error message if all classes are removed in Module "Zuweisen von Klassen zu > einem Lehrer": → OK > "Klassen der angegebenen Schule" → > "Liste der Klassen, in denen der ausgewählte Lehrer Mitglied ist" → OK > Module "Zuweisen von Klassen zu einem Lehrer": > the grid shows all group names with OU prefix; every other dialog skips the > prefix. → OK OK: Modules "Lehrer zuordnen", "Klassen zuordnen" and "Arbeitsgruppen verwalten" are accessable by the user Administrator OK: teachers are only able to use "Arbeitsgruppen verwalten" FAIL: school admins able to use "Arbeitsgruppen verwalten" and "Lehrer zuordnen" but "Klassen zuordnen" is missing. → REOPEN: The UMC operation set for the new module flavor (usually assigned to school administrators) is missing in the join script > (not sure where the mixture of german/english in the screenshot comes from, this should probably be part of another bug) → Haven't noticed this during QA → OK
The ACL's for schooladmins have been adapted (svn r60318).
(In reply to Florian Best from comment #13) > The ACL's for schooladmins have been adapted (svn r60318). OK: ACLs OK: changelog REOPEN: assigning users with role "lehrer und mitarbeiter" via "klassen zuordnen" does not work 29.04.15 00:49:25.467 MODULE ( ERROR ) : Could not add teacher uid=schulleitung1,cn=lehrer und mitarbeiter,cn=users,ou=gsmitte,dc=nstx,dc=local to class cn=gsmitte-2A,cn=klassen,cn=schueler,cn=groups,ou=gsmitte,dc=nstx,dc=local: 29.04.15 00:49:25.473 MODULE ( ERROR ) : Could not add teacher uid=schulleitung1,cn=lehrer und mitarbeiter,cn=users,ou=gsmitte,dc=nstx,dc=local to class cn=gsmitte-1a,cn=klassen,cn=schueler,cn=groups,ou=gsmitte,dc=nstx,dc=local:
(In reply to Sönke Schwardt-Krummrich from comment #14) > REOPEN: assigning users with role "lehrer und mitarbeiter" via "klassen > zuordnen" does not work Worksforme, ucs-school-umc-groups 4.0.0-9.71.201504301651
Just found out, that it does not work if a school admin is used.
(In reply to Sönke Schwardt-Krummrich from comment #16) > Just found out, that it does not work if a school admin is used. ah yes, the changes are now written via machine account (svn r60352). Package currently builds.
OK: Checked on Singleserver and Multiserver → VERIFIED
UCS@school 4.0 R2 v1 has been released: http://docs.univention.de/release-notes-ucsschool-4.0R2v1-de.html If this error occurs again, please use "Clone This Bug".