Bug 32462 - Installer is still using dhcp3
Installer is still using dhcp3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UCS Installer
UCS 5.0
Other Linux
: P5 minor (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Arvid Requate
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-02 16:23 CEST by Philipp Hahn
Modified: 2021-05-25 16:02 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-09-02 16:23:24 CEST
debian/control: isc-dhcp-client | dhcp3-client
sbin/univention-installer-network-startup:                      mkdir -p /var/lib/dhcp3/

/var/lib/dhcp3/ is dead, /var/lib/dhcp/ is correct.
So far I only noticed an error message, which doesn't cause harm otherwise.

diff --git a/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/debian/control b/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/debian/control
index 10ddc83..6bc8788 100644
--- a/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/debian/control
+++ b/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/debian/control
@@ -27,7 +27,7 @@ Description: UCS installer environment
 Package: univention-installer-modules
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends},
- isc-dhcp-client | dhcp3-client
+ isc-dhcp-client
 Description: UCS installer modules
  .
  This package is part of Univention Corporate Server (UCS),
diff --git a/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/sbin/univention-installer-network-startup b/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/sbin/univention-installer-network-startup
index a60f714..5d194cb 100755
--- a/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/sbin/univention-installer-network-startup
+++ b/branches/ucs-3.2/ucs-3.2-0/base/univention-installer/sbin/univention-installer-network-startup
@@ -100,7 +100,7 @@ for interface in $interfaces; do
                if [ -z "$address" -o -z "$netmask" ]; then
                        ifconfig $interface up
                        outfile="/tmp/dhclient-$interface.$$"
-                       mkdir -p /var/lib/dhcp3/
+                       mkdir -p /var/lib/dhcp
                        dhclient -1 \
                                -sf /lib/univention-installer/dhclient-script-wrapper \
                                -e dhclientscript_outputfile="$outfile" \
Comment 1 Philipp Hahn univentionstaff 2017-03-29 12:18:25 CEST
base/univention-network-manager/conffiles/etc/dhcp/dhclient.conf:4:#    dhcp3-client package.
base/univention-network-manager/debian/control:33: isc-dhcp-client | dhcp3-client
Comment 2 Ingo Steuwer univentionstaff 2020-07-03 20:54:27 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
Comment 3 Philipp Hahn univentionstaff 2020-07-05 07:09:00 CEST
Lets remove that dead code now:

[feature/ucs5] a966819c13 Bug #32462 DHCP: Remove references to dhcp3
 .../conffiles/etc/dhcp/dhclient.conf               | 16 ++++----
 base/univention-network-manager/debian/control     |  2 +-
 .../debian/univention-ifplugd.postinst             | 15 +-------
 .../debian/univention-ifplugd.preinst              | 45 ----------------------
 .../debian/univention-network-common.maintscript   |  2 -
 base/univention-system-setup/debian/changelog      |  6 +++
 .../scripts/10_basis/10hostname                    |  1 -
 .../scripts/10_basis/12domainname                  |  1 -
 doc/changelog/changelog-5.0-0.xml                  |  3 ++
 services/univention-dhcp/debian/changelog          |  6 +++
 ...
 13 files changed, 25 insertions(+), 116 deletions(-)
Comment 5 Arvid Requate univentionstaff 2021-03-16 18:22:14 CET
commit 43ee92fcfb
Author: Philipp Hahn <hahn@univention.de>
Date:   Sun Jul 5 07:06:51 2020 +0200

    Bug #32462 DHCP: Remove references to dhcp3
    
    also in USS, network-manager, ucs-test


Some maintainer scripts have been re/moved via:

commit 3362c3c6e2
Author: Philipp Hahn <hahn@univention.de>
Date:   Fri Aug 9 15:11:07 2019 +0200

    Bug #43688 dhcp: Convert from runit to systemd


LGTM.
Comment 6 Florian Best univentionstaff 2021-05-25 16:02:15 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".