Description Arvid Requate 2013-09-13 11:43:02 CEST

Created attachment 5431 [details]
handle_invalid_modules.patch

univention.admin.modules.update() breaks in case an UDM module is installed without a __init__.py file. While this module is invalid, the UDM should not go into a DoS in this case. This becomes especially important in the context of Apps dynamically installing their own modules. Patch proposal attached.

================================================================================
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/univention/s4connector/s4/main.py", line 40, in <module>
    import univention.s4connector
  File "/usr/lib/pymodules/python2.6/univention/s4connector/__init__.py", line 49, in <module>
    univention.admin.modules.update()
  File "/usr/lib/pymodules/python2.6/univention/admin/modules.py", line 107, in update
    os.path.walk(dir, _walk, p)
  File "/usr/lib/python2.6/posixpath.py", line 236, in walk
    walk(name, func, arg)
  File "/usr/lib/python2.6/posixpath.py", line 228, in walk
    func(arg, top, names)
  File "/usr/lib/pymodules/python2.6/univention/admin/modules.py", line 91, in _walk
    m=__import__(mod, globals(), locals(), name)
ImportError: No module named appcenter.app
failed.
================================================================================