Univention Bugzilla – Bug 32620
improve univention-join CLI output
Last modified: 2020-06-22 14:47:24 CEST
The output lines of univention-join inconsistently sometimes ends with an ":". This makes me think I have to enter some input but I don't have to. root@slave:~# univention-join univention-join: joins a computer to an ucs domain copyright (c) 2001-2013 Univention GmbH, Germany Enter DC Master Account : Administrator Enter DC Master Password: Search DC Master: done Check DC Master: done Stop LDAP Server: done Search ldap/base done Start LDAP Server: done Search LDAP binddn done Sync time done Join Computer Account: done Sync ldap-backup.secret: done Check TLS connection done Download host certificate done Restart LDAP Server: done Sync Kerberos settings: done The trailing ":" should be removed or replaced by "...".
Long join script names also break the "nice" output: Search DC Master: done Check DC Master: done Stop LDAP Server: done Search ldap/base done Start LDAP Server: done Search LDAP binddn done Sync time done Join Computer Account: done Check TLS connection done Download host certificate done Configure 03univention-directory-listener.inst done Configure 04univention-ldap-client.inst done Configure 08univention-apache.inst done Configure 11univention-pam.inst done Configure 20univention-directory-policy.inst done Configure 20univention-join.inst done Configure 26univention-nagios-common.inst done Configure 30univention-nagios-client.inst done Configure 34univention-management-console-server.inst done Configure 34univention-management-console-web-server.inst done Configure 35univention-management-console-module-appcenter.done Configure 35univention-management-console-module-join.inst done Configure 35univention-management-console-module-lib.inst done Configure 35univention-management-console-module-mrtg.inst done Configure 35univention-management-console-module-quota.instdone Configure 35univention-management-console-module-reboot.insdone Configure 35univention-management-console-module-services.idone Configure 35univention-management-console-module-setup.instdone Configure 35univention-management-console-module-sysinfo.indone Configure 35univention-management-console-module-top.inst done Configure 35univention-management-console-module-ucr.inst done Configure 35univention-management-console-module-updater.indone Configure 36univention-management-console-module-apps.inst done Configure 81univention-nfs-server.inst done Configure 98univention-pkgdb-tools.inst done When doing the switch-over to "...", the verbs probably should be changed from imperative to progressive form, as the script isn't telling me as a user to "configure/start/stop" something, but telling be what it is doing. It also better signals that the operation might take some time and is still in progress: Searching DC master... Checking login to DC Master... Stopping local LDAP server... Resolving LDAP base DN... Starting local LDAP server... Resolving LDAP bind DN... Synchronizing time... Joining computer account... Checking TLS connection... Downloading CA and host certificate... Configuring *.inst...
*** Bug 30223 has been marked as a duplicate of this bug. ***