Bug 32647 - Show link to master on non-master systems
Show link to master on non-master systems
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Apache
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Lukas Walter
Florian Best
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-20 09:49 CEST by Alexander Kläser
Modified: 2013-11-19 06:42 CET (History)
0 users

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Logo for link to DC master (637.65 KB, image/svg+xml)
2013-10-09 15:44 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2013-09-20 09:49:55 CEST
On non-master systems, a link to the DC master needs to be shown. Also, the certificate related links are only shown on a DC master or DC backup.
Comment 1 Alexander Kläser univentionstaff 2013-09-20 09:57:05 CEST
This bug is related to the UCS start site, of course :) .
Comment 2 Alexander Kläser univentionstaff 2013-10-09 15:44:09 CEST
Created attachment 5510 [details]
Logo for link to DC master
Comment 3 Lukas Walter univentionstaff 2013-10-09 17:24:46 CEST
Mentioned points have been adapted:

- link to DC master on systems which are no DC master
- no certificate related links on systems which are neither DC master nor DC backup (only for new installations)


svn r44926: univention-apache (6.0.9-1)
Comment 4 Florian Best univentionstaff 2013-10-21 15:01:14 CEST
I would adapt the Changelog 
"""On systems which are no domain controller master, the UCS overview page will contain a link to the domain controller master. On systems which neither are domain controller master nor domain controller backups, certificate related links will not be shown anymore"""
 to 
"""The UCS overview page will now display the domain certificate (and revocation list) only on domaincontroller master and backup systems. Additional on systems which aren't domaincontroller masters a link to the master is shown."""

* The certificate variables must be removed from non-master/non-backup systems if they exists in UCS 3.1.
* The german label differs from the english:
German: 'Domaincontroller Master'
English: $ldap_master
* Please put the variables you use in if clauses into double quotes.

+               ucs/web/overview/entries/admin/ldap-master/link?"http://$ldap_master" \
→ please add a trailing slash to the url
Comment 5 Alexander Kläser univentionstaff 2013-10-22 14:16:03 CEST
(In reply to Florian Best from comment #4)
> I would adapt the Changelog 
> ...

Now changelog needed as the behaviour has not changed (3.1 vs 3.2).
Comment 6 Lukas Walter univentionstaff 2013-10-22 15:21:00 CEST
(In reply to Alexander Kläser from comment #5)
> (In reply to Florian Best from comment #4)
> > I would adapt the Changelog 
> > ...
> 
> Now changelog needed as the behaviour has not changed (3.1 vs 3.2).

I've removed the changelog entry.

         
> ucs/web/overview/entries/admin/ldap-master/link?"http://$ldap_master" \
> → please add a trailing slash to the url

Added ->  svn 45437 :univention-apache (6.0.12-2)
Comment 7 Florian Best univentionstaff 2013-10-22 15:44:08 CEST
Oh, and i forgot: please use an HTTPS link.
Comment 8 Florian Best univentionstaff 2013-10-22 15:49:46 CEST
The URL should also be /ucs-overview/?lang=(DE|EN) as it was before.
Comment 9 Lukas Walter univentionstaff 2013-10-22 15:59:11 CEST
univention-apache (6.0.12-3) unstable; urgency=low
   
    * prefer https link to ldap master (Bug #32647)


svn 45445
Comment 10 Florian Best univentionstaff 2013-10-23 11:55:56 CEST
Please also do comment #8
Comment 11 Lukas Walter univentionstaff 2013-10-23 15:29:02 CEST
(In reply to Florian Best from comment #10)
> Please also do comment #8

Done.
Comment 12 Florian Best univentionstaff 2013-10-23 16:15:01 CEST
OK
Comment 13 Alexander Kläser univentionstaff 2013-11-05 15:37:03 CET
This whole block needs to be set (additionally) in the join script of the package, during a installation ldap/master is not set (as the system is not joined yet). We would have a similar problem with a UCS appliance:

> if [ $server_role != "domaincontroller_master" ]; then
>     ucr set \
>         ucs/web/overview/entries/admin/ldap-master/icon?"/icon/50x50/domaincontroller_master.png" \
>         ucs/web/overview/entries/admin/ldap-master/label?"$ldap_master" \
>         ucs/web/overview/entries/admin/ldap-master/label/de?"Domaincontroller Master" \
>         ucs/web/overview/entries/admin/ldap-master/description?"Domaincontroller Master of UCS domain $domainname" \
>         ucs/web/overview/entries/admin/ldap-master/description/de?"Domänencontroller Master der UCS Domäne $domainname" \
>         ucs/web/overview/entries/admin/ldap-master/link?"https://$ldap_master/ucs-overview/?lang=en" \
>         ucs/web/overview/entries/admin/ldap-master/link/de?"https://$ldap_master/ucs-overview/?lang=de" \
>         ucs/web/overview/entries/admin/ldap-master/priority?"09"
> fi

Also the value for the UCR variable ucs/web/overview/entries/admin/ldap-master/label is incorrect.
Comment 14 Lukas Walter univentionstaff 2013-11-06 12:51:39 CET
(In reply to Alexander Kläser from comment #13)
> This whole block needs to be set (additionally) in the join script of the
> package, during a installation ldap/master is not set (as the system is not
> joined yet). We would have a similar problem with a UCS appliance:
> 
> > if [ $server_role != "domaincontroller_master" ]; then
> >     ucr set \
> >         ucs/web/overview/entries/admin/ldap-master/icon?"/icon/50x50/domaincontroller_master.png" \
> >         ucs/web/overview/entries/admin/ldap-master/label?"$ldap_master" \
> >         ucs/web/overview/entries/admin/ldap-master/label/de?"Domaincontroller Master" \
> >         ucs/web/overview/entries/admin/ldap-master/description?"Domaincontroller Master of UCS domain $domainname" \
> >         ucs/web/overview/entries/admin/ldap-master/description/de?"Domänencontroller Master der UCS Domäne $domainname" \
> >         ucs/web/overview/entries/admin/ldap-master/link?"https://$ldap_master/ucs-overview/?lang=en" \
> >         ucs/web/overview/entries/admin/ldap-master/link/de?"https://$ldap_master/ucs-overview/?lang=de" \
> >         ucs/web/overview/entries/admin/ldap-master/priority?"09"
> > fi
> 
> Also the value for the UCR variable
> ucs/web/overview/entries/admin/ldap-master/label is incorrect.

It will be done ONLY in the join script.
The join script version has been increased to have the new UCRVs created when updating, too.
Comment 15 Alexander Kläser univentionstaff 2013-11-07 11:29:20 CET
Looks good → VERIFIED
Comment 16 Florian Best univentionstaff 2013-11-12 08:54:25 CET
(In reply to Alexander Kläser from comment #15)
> Looks good → VERIFIED
No does not, Bug #33099 comment 1
Comment 17 Stefan Gohmann univentionstaff 2013-11-19 06:42:51 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".