Bug 32715 - Fix 51_samba4/35smbclient_auth
Fix 51_samba4/35smbclient_auth
Status: CLOSED FIXED
Product: UCS Test
Classification: Unclassified
Component: Samba
unspecified
All Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Philipp Hahn
Stefan Gohmann
: interim-3
Depends on: 31256
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-27 19:50 CEST by Philipp Hahn
Modified: 2013-11-19 06:43 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-09-27 19:50:25 CEST
+++ This bug was initially created as a clone of Bug #31256 +++
root@master501:~# /usr/share//ucs-test/51_samba4/35smbclient_auth -f
...
session setup failed: NT_STATUS_IO_TIMEOUT
...
3 of 24 have been successfull.
...
Test failed

The test internally does a
  # ucr set homedir/mount=false
for the duration of the test, but still fails. I tracked it down to some timing problem with samba itself: By default the test does 8 authentication attempts in 5 seconds, repeated 3 times. This is too fast: If I increase it to 6 seconds, it works.
I think Samba has some rate limiting feature to prevent denial-of-service attacks or only has a limited socket.accept()-length.

I rewrote the test do
- be more robust: forkes smbclient don't mess with the tests stdin,stdout,stderr
- easier to read: small functions whith a limited purpose
- easier to follow: prints more progress information
- not use pyexpect: the Python code is shorter
- be cleaner: unused variables removed
- correct: the test is only "careful", because it creates a temporary user
Comment 1 Philipp Hahn univentionstaff 2013-09-27 20:10:08 CEST
r44556 | Bug #32715: 51_samba4/35smbclient_auth: Fix test
r44558 | Bug #32715,Bug #31819: ucs-test smbauth,unbuffered

ChangeLog: An improved test case for concurrent authenticated smbclient sessions is now available (Bug 26807, Bug 32715).
Comment 2 Philipp Hahn univentionstaff 2013-09-30 08:34:12 CEST
r44562 | Bug #32715: 51_samba4/35smbclient_auth: Fix dummy function
ucs-test_4.0.124-2.590.201309300831
Comment 4 Stefan Gohmann univentionstaff 2013-10-24 16:20:06 CEST
Code: OK
Test: OK
Changelog: OK
Comment 5 Stefan Gohmann univentionstaff 2013-11-19 06:43:02 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".