Bug 33008 - Nobody calls ldap_available.sh anymore
Nobody calls ldap_available.sh anymore
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Florian Best
:
Depends on:
Blocks: 51683
  Show dependency treegraph
 
Reported: 2013-10-29 20:19 CET by Philipp Hahn
Modified: 2021-05-25 16:02 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments
ldap_available.sh in Python (6.93 KB, patch)
2013-10-29 20:19 CET, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-10-29 20:19:33 CET
Created attachment 5539 [details]
ldap_available.sh in Python

ldap_available.sh was last called in UCS-3.0
 ucs-3.0/ucs/base/univention-system-setup/usr/share/univention-system-setup/univention-system-setup:
  testpipe = os.popen('/usr/lib/univention-system-setup/scripts/ldap_available.sh')

So after running setup-join.sh the file /var/run/univention-system-setup.ldap is created containing "no-ldap".
The file is not removed explicitly, but only after reboot by /lib/init/bootclean.sh.
Until then no LDAP objects are updated by calling UMC basic setup again.

It should probably be called once from umc/python/setup/util.py#run_scripts() just before calling the scripts.
It should also be rewritten in Python anyway, see attached patch.
Comment 1 Florian Best univentionstaff 2017-07-06 10:38:54 CEST
/usr/lib/univention-system-setup/scripts/setup-join.sh contains:
echo "no-ldap" > /var/run/univention-system-setup.ldap

should this be changed to the script-call, too?
Comment 2 Ingo Steuwer univentionstaff 2020-07-03 20:54:31 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
Comment 3 Philipp Hahn univentionstaff 2020-07-05 07:29:58 CEST
As there we no further bug reports regarding no-ldap, just remove the unused script.

[feature/ucs5] 64695cdbb6 Bug #33008 USS: Remove unused ldap_available.sh
 base/univention-system-setup/debian/changelog      |  1 +
 .../scripts/ldap_available.sh                      | 41 ----------------------
 doc/changelog/changelog-5.0-0.xml                  |  2 +-
 3 files changed, 2 insertions(+), 42 deletions(-)
Comment 4 Florian Best univentionstaff 2020-07-14 13:38:05 CEST
Is more cleanup necessary?
Removing the "no-ldap" evaluation? Is this another bug?
Comment 5 Philipp Hahn univentionstaff 2020-07-14 13:44:01 CEST
(In reply to Florian Best from comment #4)
> Is more cleanup necessary?
> Removing the "no-ldap" evaluation? Is this another bug?

Another bug as I lacked the deep understanding.
Comment 6 Florian Best univentionstaff 2020-07-17 12:12:24 CEST
OK: ldap_available.sh has been removed
OK: changelog entry
Comment 7 Florian Best univentionstaff 2021-05-25 16:02:17 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".