Bug 33493 – Make sure that branding.json is used in standard UMC lib files (e.g. umc/tools.js)

Bug 33493 - Make sure that branding.json is used in standard UMC lib files (e.g. umc/tools.js)


Summary:	Make sure that branding.json is used in standard UMC lib files (e.g. umc/tool...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 enhancement (vote)
Target Milestone:	UCS 3.2-0-errata
Assigned To:	Florian Best
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-20 16:59 CET by Alexander Kläser
Modified:	2014-01-29 11:21 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2013-11-20 16:59:56 CET

The translation files umc/i18n/<lang>/branding.json allow to overwrite certain messages/messageIDs for branding purposes. Not all UMC lib files import the branding translation scope (e.g, umc/tools.js).

This feature is currently needed, to display a correct info message on demo.univention.de (instead of a simple forbidden) → see Bug 33083, comment 9.

Comment 1 Florian Best

2014-01-14 10:25:35 CET

branding.json has been added to all umc-js files.

univention-management-console-frontend 3.0.152-8.805.201401141007

Comment 2 Dirk Wiesenthal

2014-01-23 17:19:03 CET

Works as expected, did not find any file you missed. But I would like to see "umc/branding" in umc/i18n.js +171, too. Otherwise internationalization could get inconsistent (although I do not know how often this feature is used). See Bug #24864.

One could even stop using params in the frontend when including umc/i18n (because branding and app are included automatically). Not sure, maybe this would be bad style (but it would have made this Bug a one-liner if this had been done before).

Comment 3 Alexander Kläser

2014-01-24 14:05:00 CET

(In reply to Dirk Wiesenthal from comment #2)
> Works as expected, did not find any file you missed. But I would like to see
> "umc/branding" in umc/i18n.js +171, too. Otherwise internationalization
> could get inconsistent (although I do not know how often this feature is
> used). See Bug #24864.
> 
> One could even stop using params in the frontend when including umc/i18n
> (because branding and app are included automatically). Not sure, maybe this
> would be bad style (but it would have made this Bug a one-liner if this had
> been done before).

Agreed, to me it seems also a good idea to include umc/branding in umc/i18n.js (instead of integrating it in the other files). Probably one could remove umc/app from the UMC .js files, as well (then simply as "umc/i18n!", I guess).

Comment 4 Florian Best

2014-01-24 14:05:53 CET

Ok

Comment 5 Florian Best

2014-01-24 17:07:03 CET

Done

Comment 6 Dirk Wiesenthal

2014-01-27 13:38:15 CET

OK

Comment 7 Alexander Kläser

2014-01-28 15:46:20 CET

I added a little check in order to ignore empty scopes and effectively avoid errors like "404 Not Found - http://192.168.122.250/i18n/de/.json".

univention-management-console-frontend (3.0.152-17):
* Bug #33493: ignore empty scopes

Comment 8 Dirk Wiesenthal

2014-01-28 16:51:06 CET

OK

Comment 9 Moritz Muehlenhoff

2014-01-29 11:21:21 CET

http://errata.univention.de/ucs/3.2/42.html