Bug 33736 - Line specific ucslint overrides e.g. as trailing source comments
Line specific ucslint overrides e.g. as trailing source comments
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: ucslint
UCS 4.4
Other Linux
: P5 enhancement (vote)
: UCS 4.4-5-errata
Assigned To: Philipp Hahn
Florian Best
:
: 42446 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-12 11:31 CET by Arvid Requate
Modified: 2020-08-12 16:18 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2013-12-12 11:31:15 CET
Currently we only have ucslint.overrides as a means to override certain ucslint checks. This can lead to a masking of errors introduced in a future commit and it is intransparent with respect to the original reason for the override. Also the overrides tend to accumulate.

It would be better to have the possibility of line-based overrides and overrides that are visible in the code. To this end, my idea would be to make overrides definable e.g. as trailing comments in the source code itself.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2013-12-12 12:13:28 CET
(In reply to Arvid Requate from comment #0)
> It would be better to have the possibility of line-based overrides and

This is already possible
→ https://forge.univention.org/bugzilla/show_bug.cgi?id=22475#c1
Comment 2 Arvid Requate univentionstaff 2013-12-12 13:30:58 CET
Ok, that's with static line numbers. The proposal here aims to enhance that solution by making this work with shifting line numbers.
Comment 3 Stefan Gohmann univentionstaff 2017-06-16 20:39:27 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 4 Philipp Hahn univentionstaff 2019-05-21 13:51:53 CEST
*** Bug 42446 has been marked as a duplicate of this bug. ***
Comment 5 Philipp Hahn univentionstaff 2019-05-21 13:52:21 CEST
Still relevant with and wanted for UCS-4.4
Comment 6 Philipp Hahn univentionstaff 2020-05-21 15:00:49 CEST
Similar to `flake8` use a tag like `# ucslint [XXXX[-YYY]]` to disable issues per like (or globally if given at the top of the file).
Comment 7 Philipp Hahn univentionstaff 2020-08-06 10:04:00 CEST
[4.4-5] dd5f1986f6 Bug #51637 et al: Merge branch 'phahn/ucslint' into 4.4-5
[4.4-5] 27097e04ab Bug #33736 ucslint: Add PEP 484 type annotation
[4.4-5] ead929786f Bug #33736 ucslint: Remove pylint controls
[4.4-5] 0bf963dfad Bug #51611 ucslint: Check for old upgrade code
[4.4-5] aca8b0a080 Bug #33736 ucslint: Line specific overrides
[4.4-5] 9ce142e02d Bug #51611 ucslint: Extract code for regular expressions
[4.4-5] 9f728fe6ac Bug #34240 ucslint: Extract code for line regexp
[4.4-5] a85d86edcd Bug #33736 ucslint: Rename UPCMessage arguments
[4.4-5] 7b27fd592b Bug #33736 ucslint: Remove unused enumerate()
[4.4-5] 152f7ec514 Bug #34240 ucslint: Fix PO flag regular expression
[4.4-5] 523f573ec3 Bug #33736 ucslint: Fix mypy typing errors
[4.4-5] 012e422a45 Bug #49240 ucslint: Print erroneous string
[4.4-5] 4ba4649874 Bug #49240 ucslint: Update comments and documentation
[4.4-5] fd133be24e Bug #49240 ucslint: Remove string formatting
[4.4-5] 25b91c7c65 Bug #51106 ucslint: Check for debian/*.pyinstall usage
[4.4-5] 5922fab3d7 Bug #49704 ucslint: Fix unicode handling
[4.4-5] 690e03f824 Bug #51107 ucspep8: Fix duplicate entry
[4.4-5] 0d94850650 Bug #28284 ucslint: Allow python3
[4.4-5] f700589a05 Bug #33737 ucslint: Check for well-known SIDs
[4.4-5] 73b8b1cf62 Bug #49240 ucslint: re-indent
[4.4-5] dfcfc5bcdb Bug #49240 ucslint: isort
[4.4-5] b1cb194e6a Bug #99999 ucslint: Check for reserved Python words
[4.4-5] 6105b4fa68 Bug #51612 ucslint: Check for more shell issues
[4.4-5] 914c042673 Bug #49620 ucslint: Check debian/changelog for errors
[4.4-5] 24b01261c3 Bug #49240 ucslint: Fix filter logic
[4.4-5] 1292292dba Bug #51246 ucslint: Ignore more debian/ files
[4.4-5] d9c6841a93 Bug #49240 ucslint: Allow ucslint on multiple packages
[4.4-5] de8635cf9f Bug #49240 ucslint: Improve sorting

Package: ucslint
Version: 8.0.0-19A~4.4.0.202008060958
Branch: ucs_4.4-0
Scope: errata4.4-5

[4.4-5] c3fddf7b9c Bug #51612: ucslint 8.0.0-19A~4.4.0.202008060958
 doc/errata/staging/ucslint.yaml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 8 Florian Best univentionstaff 2020-08-10 08:28:45 CEST
Great changes
OK: ignore statements
OK: advisory

fixed typo in README git:8c5b2c6b0fbc705414a2887d00cf20c6c89c33f3