Univention Bugzilla – Bug 34046
Multiple shell problems in univention-mrtg
Last modified: 2021-04-14 14:06:53 CEST
Created attachment 5773 [details] univention-maintenance cleanup > test -z "$mrtg_config" && touch "$mrtg_config" 2>/dev/null && { > test -z "$wwwdir" && mkdir -p "$wwwdir" 2>/dev/null && { Inverted logic; this some times leads to files being created in / > more /proc/meminfo | grep ^SwapTotal: | awk {'print $2'} > loadavg="`echo \`cat /proc/loadavg |awk '{print $3}'\`*100 | bc | cut -f1 -d"."`" ... Useless use of "cat". awk can also grep and calculate error prone quoting > rm -f $wwwdir/ucs_*.png $wwwdir/ucs_*.txt ... Missing quoting, especially when using a "rm -f" command! Contains still code to handle the old name "UDS". Still greps for univention-session, which is unused since UCS-3. debian/control: Contains historic dependencies on MTA, netcat, nmap PS: The quoted back-ticks for MRTG-Target are okay: they're interpreted by MRTG.
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4. If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
This issue has been filed against UCS 3.2. UCS 3.2 is out of maintenance and many UCS components have vastly changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.