Description Philipp Hahn 2014-02-11 14:10:54 CET

Calling univention-certificate without an arguments only returns 1:
  1 #!/bin/bash
 32 set -o errexit
 61 command="$1"
 62 shift
 65 »···if [ -n "$command" ]; then
 66 »···»···usage "unknown command: $command" >&2

The script already aborts in line 62 and doesn't reach line 65.

diff --git a/branches/ucs-3.2/ucs-3.2-0/base/univention-ssl/univention-certificate b/branches/ucs-3.2/ucs-3.2-0/base/univention-ssl/univention-certificate
index 6c64211..d1a0cf0 100755
--- a/branches/ucs-3.2/ucs-3.2-0/base/univention-ssl/univention-certificate
+++ b/branches/ucs-3.2/ucs-3.2-0/base/univention-ssl/univention-certificate
@@ -40,7 +40,7 @@ usage ()
        fi
 
        echo ""
-       echo "Usage: univention-certificate command [options] "
+       echo "Usage: ${0##*/} command [options] "
        echo ""
        echo "Commands:"
        echo "        new"
@@ -59,14 +59,11 @@ usage ()
 }
 
 command="$1"
-shift
+shift ||
+       usage >&2
 
 if [ "$command" != "new" -a "$command" != "revoke" -a "$command" != "renew" -a "$command" != "check" -a "$command" != "list" -a "$command" != "dump" ]; then
-       if [ -n "$command" ]; then
                usage "unknown command: $command" >&2
-       else
-               usage >&2
-       fi
 fi
 
 while [ $# -gt 0 ]; do