Univention Bugzilla – Bug 34217
Samba4 @school test: Deny user creation on S4 Slaves.
Last modified: 2023-03-25 06:55:01 CET
In UCS@School the creation of user objects is blocked on school servers which run Samba4. A test case should be implemented which verifies this. "samba-tool user add" may be suitable for this test.
r53186: * Bug #34217: 90_ucsschool/92_samba4_check_denied_user_creation: test user creation is denied on S4 DC-Slave.
The user creation test does not require all (currently) possible samba-tool options to be checked. Otherwise the test is ok.
(In reply to Arvid Requate from comment #2) > The user creation test does not require all (currently) possible samba-tool > options to be checked. Otherwise the test is ok. In my personal opinion, it is good idea to check all the possible options. In this particular case I've opened Bug #35754 (which is, luckily, already known in upstream and fixed in newer samba version). If you insist on removing all the options, of course, I'll do so.
The purpose of the test is to check that "the creation of user objects is blocked on school servers which run Samba4". It's goal is not to test the full set of currently available samba-tool options which might change in a new upstream release. Checking this also does not fit into ucs-test-ucsschool. Please streamline the test case accordingly.
r53854: * Bug #34217: 90_ucsschool/92_samba4_check_denied_user_creation: don't check all the possible options for user creation.
In the last Jenkins run on UCS 3.2, single master, SambaVersion=s4-with-slave, script "90_ucsschool.92_samba4_check_denied_user_creation" failed: http://jenkins.knut.univention.de:8080/view/UCSschool/job/UCSschool%203.2R2%20Singleserver/115/SambaVersion=s4-with-slave/testReport/90_ucsschool/92_samba4_check_denied_user_creation/test/ . . Obtaining Administrator username and password for the test from the UCR Attempting to create a user with a username 'ucs_test_school_user_jp6az3qf' and options: ['Foo1shjo33ofun'] ("The 'samba-tool' produced the following output to STDOUT:", "User 'ucs_test_school_user_jp6az3qf' created successfully\n") ### FAIL ### The creation of user 'ucs_test_school_user_jp6az3qf' succeded, while should be disabled on DC-Slave with Samba4 ### ###
(In reply to Ammar Najjar from comment #6) > In the last Jenkins run on UCS 3.2, single master, > SambaVersion=s4-with-slave, script > "90_ucsschool.92_samba4_check_denied_user_creation" failed: > Attempting to create a user with a username 'ucs_test_school_user_jp6az3qf' > and options: ['Foo1shjo33ofun'] > ("The 'samba-tool' produced the following output to STDOUT:", "User > 'ucs_test_school_user_jp6az3qf' created successfully\n") > ### FAIL ### > The creation of user 'ucs_test_school_user_jp6az3qf' succeded, while should > be disabled on DC-Slave with Samba4 > ### ### Sorry, maybe I did not get it, but what's the problem with the test script? It fails in Multi server setup as well: http://jenkins.knut.univention.de:8080/job/UCSschool%203.2R2%20Multiserver/114/SambaVersion=s4-school-only-with-slave/testReport/junit/90_ucsschool/92_samba4_check_denied_user_creation/test/ --> as the user creation succeeds, while it should not: root@slave202:~/90_ucsschool# samba-tool user add test_samba_user New Password: Retype Password: User 'test_samba_user' created successfully root@slave202:~/90_ucsschool# samba-tool user list http-proxy-master201 test_samba_user Administrator dns-master201 dns-slave202 join-backup join-slave krbtgt Guest
> Sorry, maybe I did not get it, but what's the problem with the test script? The test seems to work properly :-) I created Bug 37700 to check and fix this in UCS@school.