Description Philipp Hahn 2014-04-07 13:50:19 CEST

Created attachment 5856 [details]
Exception hierarchy for UMCConnection lib + cleanup.

base/univention-lib/python/umc_connection.py#UMCConnection() raises and passes through several different exception classes, which are not below some common base exception. This complicates error handling, as "Exception" must be caught which catches too much:

			raise ValueError('No cookie')
		raise NotImplementedError('command forbidden: %s' % url)
	raise HTTPException(error_message)

It would be better to introduce a new base error class like
 class UMCConnectionError(HTTPException): pass
 class UMCConnectionUnknownCommand(UMCConnectionError): pass
 class UMCConnectionRequestError(UMCConnectionError): pass
and to not raise an NotImplementedError(), as that error is reserved for a completely different set of errors in Python.