For refactoring the CLI tool "create_ou" all functions should be tested via ucs-test. Currently the tool uses it's own implementation (which shall be used as reference!). The upcoming UCS@school import library will provide the same functionality as the import CLI tools and will be used within the CLI tools in near future. Ideally the test script is able to test the CLI tool as well as the import lib.
CLI interface tests have been added: r49740
The test case "import_ou_with_existing_dc(use_cli_api=True)" should call "move_domaincontroller_to_ou --dcname <dcname> --ou <ou>" directly after creating the OU and before verifying the OU structure. Otherwise the test will fail.
(In reply to Sönke Schwardt-Krummrich from comment #2) > The test case "import_ou_with_existing_dc(use_cli_api=True)" should call > "move_domaincontroller_to_ou --dcname <dcname> --ou <ou>" directly after > creating the OU and before verifying the OU structure. Otherwise the test > will fail. This has been fixed. The fix from Bug #34767 is needed for this test.
Is it okay that the subnet address is hardcoded as '10.20.30.0'?
(In reply to Florian Best from comment #4) > Is it okay that the subnet address is hardcoded as '10.20.30.0'? I would say "yes". Not optimal, but okay for now.