Bug 34837 – It's possible to open the UCS@school installer twice within the same UMC session

Bug 34837 - It's possible to open the UCS@school installer twice within the same UMC session


Summary:	It's possible to open the UCS@school installer twice within the same UMC session

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Installer
Version:	UCS@school 3.2 R2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 3.2 R2
Assigned To:	Florian Best
QA Contact:	Sönke Schwardt-Krummrich

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-15 10:27 CEST by Sönke Schwardt-Krummrich
Modified:	2014-06-12 09:20 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Set unique: true on module (779 bytes, patch) 2014-05-19 23:42 CEST, Dirk Wiesenthal	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sönke Schwardt-Krummrich

2014-05-15 10:27:13 CEST

Currently it's possible to open the UCS@school installer twice within the same UMC session. This should be avoided, because the first one may be in installation phase while the second one shows an unconfigured system.

Comment 1 Dirk Wiesenthal

2014-05-15 14:28:04 CEST

This is simply

declare('module', function() {
  unique: true
})

in the JS code

Comment 2 Sönke Schwardt-Krummrich

2014-05-19 20:32:46 CEST

Tried to set "unique: true" within schoolinstaller.js but it does not seem to work. Ideas?

Comment 3 Dirk Wiesenthal

2014-05-19 23:42:13 CEST

Created attachment 5915 [details]
Set unique: true on module

This should do the trick. Untested

Comment 4 Florian Best

2014-05-20 16:41:40 CEST

ucs-school-umc-installer (2.0.16-1)

Comment 5 Sönke Schwardt-Krummrich

2014-05-20 21:06:00 CEST

OK: changelog entry
OK: code change
OK: functionality

→ verified

Comment 6 Sönke Schwardt-Krummrich

2014-06-12 09:19:24 CEST

UCS@school 3.2 R2 has been released:
http://docs.univention.de/release-notes-ucsschool-3.2R2-de.html

If this error occurs again, please use "Clone This Bug".