Bug 35022 – univention-add-app registers ucs/web/overview variables even when not installing the app

Bug 35022 - univention-add-app registers ucs/web/overview variables even when not installing the app


Summary:	univention-add-app registers ucs/web/overview variables even when not install...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - App-Center
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.2-2-errata
Assigned To:	Dirk Wiesenthal
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-30 11:33 CEST by Dirk Wiesenthal
Modified:	2014-07-08 16:12 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2014-05-30 11:33:59 CEST

univention-add-app app_id $app_id --latest --master

should install only the master packages of $app_id. These are normally UDM modules or LDAP schema extensions. But univention-add-app _always_ sets UCR variables for the UMC overview, so that (if $app_id defines an WebInterface) there is a link in ucs-overview leading to nowhere.

univention-add-app is the "fallback" command suggested by us if backups are not reachable during installation.

Maybe also used in some custom setups.

Note that this is not really the fault of univention-add-app. app.register() does not provide an option to skip UCR registration

Comment 1 Stefan Gohmann

2014-06-17 08:08:03 CEST

Do we have an app where it goes wrong?

Comment 2 Dirk Wiesenthal

2014-06-17 10:00:21 CEST

Yes, a lot.

Every app with WebInterface and DefaultPackagesMaster. This error may not be so common because one runs this command on DC Backups when an installation went wrong there.

But potentially a lot of apps have this issue.

Comment 3 Dirk Wiesenthal

2014-06-25 16:26:15 CEST

Fixed in
  univention-updater 9.0.41-2.1257.201406251547

The legacy call

univention-add-app $component $pkg1 $pkg2 [...]

is difficult to maintain. We should really consider removing it!

Comment 4 Alexander Kläser

2014-07-07 10:58:39 CEST

(In reply to Dirk Wiesenthal from comment #3)
> Fixed in
>   univention-updater 9.0.41-2.1257.201406251547
> 
> The legacy call
> 
> univention-add-app $component $pkg1 $pkg2 [...]
> 
> is difficult to maintain. We should really consider removing it!

I opened Bug 35279 for that.

Comment 5 Alexander Kläser

2014-07-07 12:47:06 CEST

In my tests I could verify, that an installation with --master will not anymore set UCR variables for the UCS overview package. However, when calling with --all (instead of --master), the variables are set correctly.

YAML file → OK

→ VERIFIED

Comment 6 Moritz Muehlenhoff

2014-07-08 16:12:38 CEST

http://errata.univention.de/ucs/3.2/137.html