Bug 35487 - univention-tftp: should depend only on syslinux-common
univention-tftp: should depend only on syslinux-common
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UCS Net Installer
UCS 5.0
Other Linux
: P5 minor (vote)
: UCS 5.0-0-errata
Assigned To: Philipp Hahn
Jürn Brodersen
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-28 14:03 CEST by Philipp Hahn
Modified: 2021-06-16 17:36 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2014-07-28 14:03:14 CEST
The required /usr/lib/syslinux/pxelinux.0 is in the binary package "syslinux-common" (or in "pxelinux" with newer syslinux-6 like in Debian-Jessie).

The binary package "syslinux" only contains some (unneeded) binary programs to use syslinux as a MBR bootloader or isolinux for building CD/DVDs:
$ dpkg -L syslinux
/usr/bin/syslinux
/usr/bin/isohybrid
/usr/bin/gethostip
/usr/bin/memdiskfind
Comment 1 Stefan Gohmann univentionstaff 2017-06-16 20:38:40 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 2 Stefan Gohmann univentionstaff 2017-08-08 07:10:30 CEST
This issue has been filed against UCS 3.2.

UCS 3.2 is out of maintenance and many UCS components have vastly changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.
Comment 3 Ingo Steuwer univentionstaff 2020-07-03 20:50:59 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
Comment 4 Philipp Hahn univentionstaff 2020-07-04 06:53:55 CEST
Still present - since 6 years
Comment 6 Philipp Hahn univentionstaff 2021-06-09 09:18:12 CEST
# diffoscope --text-color always --exclude-directory-metadata=recursive univention-tftp_11.0.0-1A~5.0.0.202009231605_all.deb univention-tftp_11.0.0-2_all.deb
--- univention-tftp_11.0.0-1A~5.0.0.202009231605_all.deb
+++ univention-tftp_11.0.0-2_all.deb
├── control.tar.xz
│ ├── control.tar
│ │ ├── file list
│ │ │ @@ -1,7 +1,8 @@
│ │ │  ./
│ │ │  ./conffiles
│ │ │  ./control
│ │ │  ./md5sums
│ │ │  ./postinst
│ │ │ +./postrm
│ │ │  ./preinst
│ │ │  ./prerm
│ │ ├── ./control
│ │ │ @@ -1,13 +1,13 @@
│ │ │  Package: univention-tftp
│ │ │ -Version: 11.0.0-1A~5.0.0.202009231605
│ │ │ +Version: 11.0.0-2
│ │ │  Architecture: all
│ │ │  Maintainer: Univention GmbH <packages@univention.de>
│ │ │ -Installed-Size: 33
│ │ │ -Depends: atftpd, pxelinux, syslinux, univention-config (>= 7.0.25)
│ │ │ +Installed-Size: 34
│ │ │ +Depends: atftpd, pxelinux, syslinux-common, univention-config (>= 7.0.25)
│ │ │  Replaces: univention-client-boot-pxe
│ │ │  Section: univention
│ │ │  Priority: optional
│ │ │  Description: UCS - TFTP server
│ │ │   This packages installs a TFTP server, which can be used
│ │ │   by computers booting off the network to receive their
│ │ │   operating system (such as UCS thin clients).
│ │ ├── ./md5sums
│ │ │ ├── ./md5sums
│ │ │ │┄ Files differ
│ │ ├── ./postinst
│ │ │ @@ -1,13 +1,10 @@
│ │ │  #! /bin/sh
│ │ │  #
│ │ │ -# Univention TFTP
│ │ │ -#  postinst script
│ │ │ -#
│ │ │ -# Copyright 2004-2020 Univention GmbH
│ │ │ +# Copyright 2004-2021 Univention GmbH
│ │ │  #
│ │ │  # https://www.univention.de/
│ │ │  #
│ │ │  # All rights reserved.
│ │ │  #
│ │ │  # The source code of this program is made available
│ │ │  # under the terms of the GNU Affero General Public License version 3
│ │ │ @@ -26,31 +23,35 @@
│ │ │  # GNU Affero General Public License for more details.
│ │ │  #
│ │ │  # You should have received a copy of the GNU Affero General Public
│ │ │  # License with the Debian GNU/Linux or Univention distribution in file
│ │ │  # /usr/share/common-licenses/AGPL-3; if not, see
│ │ │  # <https://www.gnu.org/licenses/>.
│ │ │  
│ │ │ -if [ -e "/etc/init.d/atftpd" ]; then
│ │ │ - /etc/init.d/atftpd stop
│ │ │ -fi
│ │ │ +case "$1" in
│ │ │ +configure)
│ │ │ + [ -x /etc/init.d/atftpd ] &&
│ │ │ +         invoke-rc.d atftpd stop
│ │ │  
│ │ │  update-inetd --group BOOT --remove "tftp"
│ │ │  update-inetd --group BOOT --add "tftp               dgram   udp     wait \
│ │ │          nobody /usr/sbin/tcpd /usr/sbin/in.tftpd --tftpd-timeout 300 --retry-timeout 5 --maxthread 100 --verbose=5  /var/lib/univention-client-boot/"
│ │ │  
│ │ │ -/etc/init.d/atftpd start
│ │ │ + [ -x /etc/init.d/atftpd ] &&
│ │ │ +         invoke-rc.d atftpd start
│ │ │ +
│ │ │ +# configure firewall
│ │ │ +ucr set security/packetfilter/package/univention-tftp/udp/69/all=ACCEPT \
│ │ │ +         security/packetfilter/package/univention-tftp/udp/69/all/en="TFTP"
│ │ │ +[ -x "/etc/init.d/univention-firewall" ] && invoke-rc.d univention-firewall restart
│ │ │ +;;
│ │ │ +esac
│ │ │  
│ │ │  # Automatically added by univention-install-config-registry
│ │ │  if [ "$1" = "abort-remove" ]; then
│ │ │    [ -e /etc/univention/templates/removed/univention-tftp.info ] && mv /etc/univention/templates/removed/univention-tftp.info /etc/univention/templates/info/univention-tftp.info || true
│ │ │  fi
│ │ │  [ -x /usr/sbin/univention-config-registry ] && univention-config-registry register univention-tftp || true
│ │ │  # End automatically added section
│ │ │  
│ │ │  
│ │ │ -# configure firewall
│ │ │ -ucr set security/packetfilter/package/univention-tftp/udp/69/all=ACCEPT \
│ │ │ -         security/packetfilter/package/univention-tftp/udp/69/all/en="TFTP"
│ │ │ -[ -x "/etc/init.d/univention-firewall" ] && invoke-rc.d univention-firewall restart
│ │ │ -
│ │ │  exit 0
│ │ ├── ./prerm
│ │ │ @@ -1,48 +1,8 @@
│ │ │ -#! /bin/sh
│ │ │ -#
│ │ │ -# Univention TFTP
│ │ │ -#  prerm script
│ │ │ -#
│ │ │ -# Copyright 2004-2020 Univention GmbH
│ │ │ -#
│ │ │ -# https://www.univention.de/
│ │ │ -#
│ │ │ -# All rights reserved.
│ │ │ -#
│ │ │ -# The source code of this program is made available
│ │ │ -# under the terms of the GNU Affero General Public License version 3
│ │ │ -# (GNU AGPL V3) as published by the Free Software Foundation.
│ │ │ -#
│ │ │ -# Binary versions of this program provided by Univention to you as
│ │ │ -# well as other copyrighted, protected or trademarked materials like
│ │ │ -# Logos, graphics, fonts, specific documentations and configurations,
│ │ │ -# cryptographic keys etc. are subject to a license agreement between
│ │ │ -# you and Univention and not subject to the GNU AGPL V3.
│ │ │ -#
│ │ │ -# In the case you use this program under the terms of the GNU AGPL V3,
│ │ │ -# the program is provided in the hope that it will be useful,
│ │ │ -# but WITHOUT ANY WARRANTY; without even the implied warranty of
│ │ │ -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
│ │ │ -# GNU Affero General Public License for more details.
│ │ │ -#
│ │ │ -# You should have received a copy of the GNU Affero General Public
│ │ │ -# License with the Debian GNU/Linux or Univention distribution in file
│ │ │ -# /usr/share/common-licenses/AGPL-3; if not, see
│ │ │ -# <https://www.gnu.org/licenses/>.
│ │ │ -
│ │ │ -update-inetd --group BOOT --disable tftp
│ │ │ -
│ │ │ -if [ "$1" = "purge" ]; then
│ │ │ - rm -f /etc/atftpd.conf
│ │ │ -fi
│ │ │ -
│ │ │ +#!/bin/sh
│ │ │ +set -e
│ │ │  # Automatically added by univention-install-config-registry
│ │ │  if [ "$1" = "remove" ] && [ -e /etc/univention/templates/info/univention-tftp.info ] ; then
│ │ │    [ -x /usr/sbin/univention-config-registry ] && univention-config-registry unregister univention-tftp || true
│ │ │    mv /etc/univention/templates/info/univention-tftp.info /etc/univention/templates/removed/univention-tftp.info || true
│ │ │  fi
│ │ │  # End automatically added section
│ │ │ -
│ │ │ -
│ │ │ -exit 0
│ │ │ -
├── data.tar.xz
│ ├── data.tar
│ │ ├── ./usr/share/doc/univention-tftp/changelog.Debian.gz
│ │ │ ├── filetype from file(1)
│ │ │ │ @@ -1 +1 @@
│ │ │ │ -gzip compressed data, max compression, from Unix, original size 4625
│ │ │ │ +gzip compressed data, max compression, from Unix, original size 4580
│ │ │ ├── changelog.Debian
│ │ │ │ @@ -1,12 +1,12 @@
│ │ │ │ -univention-tftp (11.0.0-1A~5.0.0.202009231605) ucs5-0-0-0; urgency=low
│ │ │ │ +univention-tftp (11.0.0-2) unstable; urgency=low
│ │ │ │  
│ │ │ │ -  * UCS auto build. No patches were applied to the original source package
│ │ │ │ +  * Bug #35487: Fix package dependencies and maintainer scripts
│ │ │ │  
│ │ │ │ - -- Univention builddaemon <buildd@univention.de>  Wed, 23 Sep 2020 16:05:00 +0200
│ │ │ │ + -- Philipp Hahn <hahn@univention.de>  Tue, 08 Jun 2021 18:22:16 +0200
│ │ │ │  
│ │ │ │  univention-tftp (11.0.0-1) unstable; urgency=medium
│ │ │ │  
│ │ │ │    * Bug #51419: UCS-5.0-0 version bump
│ │ │ │  
│ │ │ │   -- Dirk Wiesenthal <wiesenthal@univention.de>  Fri, 05 Jun 2020 18:06:32 +0200
│ │ ├── ./usr/share/doc/univention-tftp/copyright
│ │ │ @@ -1,14 +1,14 @@
│ │ │  Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
│ │ │  Upstream-Name: Univention GmbH
│ │ │  Upstream-Contact: <package@univention.de>
│ │ │  Source: https://updates.software-univention.de/
│ │ │  
│ │ │  Files: *
│ │ │ -Copyright: 2002-2020 Univention GmbH
│ │ │ +Copyright: 2002-2021 Univention GmbH
│ │ │  License: AGPL-3.0-only
│ │ │   The source code of the software contained in this package
│ │ │   as well as the source package itself are made available
│ │ │   under the terms of the GNU Affero General Public License version 3
│ │ │   (GNU AGPL V3) as published by the Free Software Foundation.
│ │ │   .
│ │ │   Binary versions of this program provided by Univention to you as
Comment 7 Philipp Hahn univentionstaff 2021-06-11 12:32:53 CEST
[5.0-0] ce2b657b8c fix[tftp]: Fix package dependencies and maintainer scripts
 doc/errata/staging/univention-tftp.yaml                                   | 10 ++++++++++
 services/univention-tftp/debian/changelog                                 |  6 ++++++
 services/univention-tftp/debian/compat                                    |  1 -
 services/univention-tftp/debian/control                                   |  4 ++--
 services/univention-tftp/debian/univention-tftp.postinst                  | 19 ++++++++++---------
 .../debian/{univention-tftp.prerm => univention-tftp.postrm}              | 15 +++++++--------
 6 files changed, 35 insertions(+), 20 deletions(-)

Package: univention-tftp
Version: 11.0.0-2A~5.0.0.202106111128
Branch: ucs_5.0-0
Scope: errata5.0-0

[5.0-0] 6aca53ce8e Bug #35487: univention-tftp 11.0.0-2A~5.0.0.202106111128
 doc/errata/staging/univention-tftp.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

FYI QA: UCS 5.0-0 no longer has support for PXE installation out-of-the box, so don't expect that to work by simply installing this package.
OK: apt install atftp && atftp $HOSTNAME 69 -g -r /pxelinux.cfg/default -l ./tmp && cat ./tmp
Comment 8 Philipp Hahn univentionstaff 2021-06-11 17:32:07 CEST
[5.0-0] e88c1cdbf6 fix[tftp]: update-inetd invocation
 services/univention-tftp/debian/changelog                | 17 +++++++++++------
 services/univention-tftp/debian/univention-tftp.postinst |  5 ++---
 services/univention-tftp/debian/univention-tftp.postrm   |  6 ++----
 3 files changed, 15 insertions(+), 13 deletions(-)

Package: univention-tftp
Version: 11.0.0-3A~5.0.0.202106111729
Branch: ucs_5.0-0
Scope: errata5.0-0

[5.0-0] 6a1261aec6 Bug #35487: univention-tftp 11.0.0-3A~5.0.0.202106111729
 doc/errata/staging/univention-tftp.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Jürn Brodersen univentionstaff 2021-06-14 10:37:52 CEST
What I tested:
"apt install atftp && atftp $HOSTNAME 69 -g -r /pxelinux.cfg/default -l ./tmp && cat ./tmp" -> OK
Install -> OK
Remove -> OK
yaml -> OK (added maintained status)

-> verified