Bug 35561 – univention-run-join-scripts --run-script foo always exits 0

Bug 35561 - univention-run-join-scripts --run-script foo always exits 0


Summary:	univention-run-join-scripts --run-script foo always exits 0

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Join (univention-join)
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0
Assigned To:	Florian Best
QA Contact:	Philipp Hahn

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-04 17:52 CEST by Arvid Requate
Modified:	2021-05-25 15:58 CEST (History)
CC List:	3 users (show)

See Also:	38983
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup, Error handling
Max CVSS v3 score:

Flags:	best: Patch_Available+

Attachments
patch (736 bytes, patch) 2017-05-12 13:46 CEST, Florian Best	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2014-08-04 17:52:28 CEST

univention-run-join-scripts --run-script foo   always exits 0, even if the script foo returns a non-zero exit status. This is unexpected behaviour and should be fixed.

Comment 1 Florian Best

2017-05-12 12:50:57 CEST

Happened also at Bug #38983.

Comment 2 Florian Best

2017-05-12 13:46:30 CEST

Created attachment 8843 [details]
patch

Comment 3 Ingo Steuwer

2020-07-03 20:51:25 CEST

This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.

Comment 4 Philipp Hahn

2020-07-04 07:17:57 CEST

Violation of least surprise

Comment 5 Florian Best

2020-09-22 09:32:29 CEST

The exit code has been corrected:

univention-join (12.0.0-3)
4c08e4ffc1af | Bug #35561: fix exitcode of univention-run-join-scripts

changelog-5.0-0.xml
67a04897eae5 | Changelog Bug #35561

Comment 6 Philipp Hahn

2020-10-15 15:21:45 CEST

OK: 4c08e4ffc1af
OK: 67a04897eae5
OK: cat /usr/lib/univention-install/09Test.inst 
 #!/bin/bash
 VERSION=1
 . /usr/share/univention-join/joinscripthelper.lib
 joinscript_init
 exit 2
 joinscript_save_current_version
 exit 0
 univention-run-join-scripts ; echo $? # 1

Comment 7 Florian Best

2021-05-25 15:58:32 CEST

UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".