Bug 35700 - Traceback when using non-valid search values (= pkgdb unusable)
Traceback when using non-valid search values (= pkgdb unusable)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: pkgdb
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-0-errata
Assigned To: Florian Best
Janek Walkenhorst
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-26 11:57 CEST by Dirk Wiesenthal
Modified: 2016-02-22 11:32 CET (History)
7 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Error handling, External feedback
Max CVSS v3 score:
best: Patch_Available+


Attachments
pkgdb.patch (1.88 KB, patch)
2014-09-08 10:13 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2014-08-26 11:57:23 CEST
Reported by Traceback feedback.

 Traceback:
Die Ausführung des Kommandos pkgdb/proposals ist fehlgeschlagen:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/__init__.py",
line 218, in execute
    func( request )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py",
line 178, in _response
    return function(self, request)
  File
"/usr/lib/pymodules/python2.6/univention/management/console/modules/pkgdb/__init__.py",
line 221, in _connect
    func(self, *args, **kwargs)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py",
line 305, in _response
    result = _multi_response(self, request)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py",
line 432, in _response
    for res in function(self, iterator, *nones):
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py",
line 271, in _fake_func
    yield function(self, *args)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/decorators.py",
line 579, in _response
    result = function(self, *args)
  File
"/usr/lib/pymodules/python2.6/univention/management/console/modules/pkgdb/__init__.py",
line 311, in proposals
    return _combobox_data(PROPOSALS[key])
  File
"/usr/lib/pymodules/python2.6/univention/management/console/modules/pkgdb/__init__.py",
line 329, in _combobox_data
    return [dict(id=identifier, label=_id_to_label(identifier)) for identifier in data]
TypeError: 'NoneType' object is not iterable


Remark:
Traceback erscheint bei uns, wenn im Software-Monitor im Dropdown "Suche nach:" einfach
ein anderer Eintrag ausgewählt wird.
Comment 1 Florian Best univentionstaff 2014-09-08 09:52:30 CEST
Reported again with remark:
Im Software-Monitor unter Systeme i Feld "Suche nach" den Wert  "Systemrolle" auswählen
Comment 2 Florian Best univentionstaff 2014-09-08 10:13:22 CEST
Created attachment 6097 [details]
pkgdb.patch

Bug #34723 introduced this, it is caused by a missing return in a added decorator.
It makes the module really unusable, a patch is attached which also fixes the language of the translation and the reconnection to postgres if it fails.
Comment 3 Florian Best univentionstaff 2014-10-06 10:09:15 CEST
Reported again.
Comment 4 Tim Petersen univentionstaff 2014-10-14 08:40:03 CEST
Reported at 2014101321000427
Comment 5 Janis Meybohm univentionstaff 2014-11-05 14:11:07 CET
Still valid für 4.0 (at least RC)
Comment 6 Florian Best univentionstaff 2014-11-20 12:49:52 CET
Reported again.
Comment 7 Florian Best univentionstaff 2014-11-20 14:01:34 CET
(In reply to Florian Best from comment #6)
> Reported again.

Twice, from different UUIDs.
Comment 8 Florian Best univentionstaff 2014-11-20 14:02:21 CET
Remark:
Im Softwaremonitor die Systemrolle abgefragt ohne vorher eine andere Operation gemacht zu
haben.
Die Rolle ist Slave, installiert ist Zarafa (über AppCenter)

Grüße
Comment 9 Florian Best univentionstaff 2014-11-20 14:13:02 CET
(In reply to Florian Best from comment #7)
> (In reply to Florian Best from comment #6)
> > Reported again.
> 
> Twice, from different UUIDs.
A third time from another UUID.
Comment 10 Florian Best univentionstaff 2014-11-24 09:53:44 CET
Again reported, 3.2-4 errata241 (Borgfeld)
Comment 11 Florian Best univentionstaff 2014-11-29 00:31:07 CET
Fixed, 2014-11-28-univention-pkgdb.yaml
Comment 12 Florian Best univentionstaff 2014-12-01 13:52:34 CET
The patch also fixed the translation of error message strings and it makes sure that after a failed command the connection to the postgresql server ist reconnected in any case.
Comment 13 Janek Walkenhorst univentionstaff 2014-12-01 13:53:49 CET
Code review: OK
Tests: OK
Advisory: OK
Comment 14 Moritz Muehlenhoff univentionstaff 2014-12-04 12:20:38 CET
http://errata.univention.de/ucs/4.0/5.html
Comment 15 Florian Best univentionstaff 2016-02-22 11:32:09 CET
Reported again, 3.2-8 errata401 (Borgfeld)