Bug 35711 - Duplicated email registration/activation - Appliance + UMC wizard
Duplicated email registration/activation - Appliance + UMC wizard
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 3.2-3-errata
Assigned To: Alexander Kramer
Dirk Wiesenthal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-26 22:01 CEST by Stefan Gohmann
Modified: 2014-09-10 17:47 CEST (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2014-08-26 22:01:20 CEST
The appliance wizard asks for the email address and the UMC wizard does the same. That means the user is asked for two times within a few minutes.

I think the UMC wizard should not ask for the email address if the email address was insert in the appliance wizard.
Comment 1 Alexander Kramer univentionstaff 2014-09-03 11:15:21 CEST
Created a new ucr variable umc/web/activation_email to prevent double registration

UCS 3.2-3:
r53277, r53278

Adapted the YAML file for univention-system-setup
Created a YAML file for univention-management-console-frontend
r53283

Source: univention-system-setup
Version: 7.0.69-55

Source: univention-management-console-frontend
Version: 3.0.152-41

----

UCS 4.0-0
r53285, r53287

Package: univention-system-setup
Version: 8.0.35-4.664.201409031048

Package: univention-management-console-frontend
Version: 4.0.3-3.852.201409031101
Comment 2 Alexander Kläser univentionstaff 2014-09-03 12:35:13 CEST
Instead of
> return Boolean(ucr['uuid/license']) || Boolean(ucr['umc/web/activation_email']);
please use
> return Boolean(ucr['uuid/license']) || tools.isTrue(ucr['umc/web/activation_email']);
Comment 3 Alexander Kramer univentionstaff 2014-09-03 15:17:16 CEST
Ty for the suggestion. I adapted the files as requested:

r53296, r53297

Package: univention-management-console-frontend
Version: 3.0.152-42.853.201409031502
Scope: errata3.2-3

Package: univention-management-console-frontend
Version: 4.0.3-4.854.201409031503
Branch: ucs_4.0-0
Comment 4 Alexander Kramer univentionstaff 2014-09-04 07:53:49 CEST
Adapted the package version in the yaml file for the frontend modul to:
3.0.152-42.853.201409031502

r53337
Comment 5 Dirk Wiesenthal univentionstaff 2014-09-08 11:28:52 CEST
You are setting the UCR variable in univention-system-setup/cleanup-post.d/30_activate_license

I suggest doing it in udm/request_new_license (umc-module-udm) - if the activation fails for some reason (e.g., no internet connection) the variable is set to true nonetheless.
Comment 6 Alexander Kramer univentionstaff 2014-09-08 15:58:23 CEST
Adapted the files as you suggested. Now the ucr variable will be only set, if the request was successful. Tested it with a locally build on a ucs 4.0-0 vm.

UCS 3.2-3:
r 53437

Successful build
Package: univention-management-console-module-udm
Version: 4.0.99-5.475.201409081539
Scope: errata3.2-3

Package: univention-system-setup
Version: 7.0.69-60.671.201409081540
User: akramer
Branch: ucs_3.2-0
Scope: errata3.2-3

Adapted the yaml files: r53441
----

UCS 4.0-0:
r53435, r53436, r53438
Successful build
Package: univention-management-console-module-udm
Version: 5.0.4-2.474.201409081523
Branch: ucs_4.0-0

Package: univention-system-setup
Version: 8.0.37-2.672.201409081546
Branch: ucs_4.0-0
Comment 7 Dirk Wiesenthal univentionstaff 2014-09-10 10:43:12 CEST
Works fine.

Please rename the UCR variable to ucs/web/license/requested as the current name somehow indicates that the value is the email used.

Please remove the bug number in system-setup.yaml as the system-setup patch was reverted. The bug should be mentioned in umc-frontend and umc-module-udm
Comment 8 Alexander Kramer univentionstaff 2014-09-10 11:59:33 CEST
ucs 3.2-3:
renamed the variable in udm and frontend:
r53517, 53520

Successful build
Package: univention-management-console-frontend
Version: 3.0.152-43.855.201409101048
Scope: errata3.2-3

Package: univention-management-console-module-udm
Version: 4.0.99-6.476.201409101112
Scope: errata3.2-3

removed the bug number and description from the system setup yaml-file
adapted the fix number for the udm and frontend yaml file
r53523
----

same for ucs4.0-0:
r53522

Successful build
Package: univention-management-console-frontend
Version: 4.0.3-5.856.201409101128
Branch: ucs_4.0-0

Package: univention-management-console-module-udm
Version: 5.0.4-3.477.201409101148
Branch: ucs_4.0-0
Comment 9 Alexander Kramer univentionstaff 2014-09-10 14:16:33 CEST
Adapted univention-management-console-frontend/umc/app/StartupDialog.js
to check for ucs/web/license/requested instead of ucs/web/license/requested=true

ucs3.2-3:
r53537

Successful build
Package: univention-management-console-frontend
Version: 3.0.152-44.857.201409101350
Scope: errata3.2-3

r53540: Adapted the frontend yaml file

----
ucs4.0-0:
r53539

Successful build
Package: univention-management-console-frontend
Version: 4.0.3-6.858.201409101358
Branch: ucs_4.0-0
Comment 10 Dirk Wiesenthal univentionstaff 2014-09-10 14:31:04 CEST
OK
Comment 11 Janek Walkenhorst univentionstaff 2014-09-10 17:33:56 CEST
http://errata.univention.de/ucs/3.2/187.html
Comment 12 Janek Walkenhorst univentionstaff 2014-09-10 17:47:50 CEST
http://errata.univention.de/ucs/3.2/206.html