Bug 35823 - Provide stylus as package
Provide stylus as package
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0
Assigned To: Alexander Kramer
Alexander Kläser
: interim-3
Depends on: 35822
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-04 12:02 CEST by Alexander Kläser
Modified: 2014-11-26 06:55 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2014-09-04 12:02:06 CEST
For the UMC build process, we need the CSS preprocessor Stylus. The UMC theme is written using stylus. It would be good to be able to automatically download dependencies/updates using npm.
Comment 1 Alexander Kläser univentionstaff 2014-09-04 12:21:26 CEST
I already committed an initial package such that the build process is possible for UMC.
Comment 2 Alexander Kramer univentionstaff 2014-09-10 08:45:50 CEST
r53506: Added Makefile and dependencies

Failed build
Package: stylus
Version: 0.0.0-2.3.201409100841
Branch: ucs_4.0-0

I: cleaning the build env 
I: removing directory /var/build/temp/tmp.We45OjFEEs/pbuilder/4368 and its subdirectories
rmdir: failed to remove `/var/build/temp/tmp.We45OjFEEs/pbuilder/4368/var/run/shm': Device or resource busy
rmdir: failed to remove `/var/build/temp/tmp.We45OjFEEs/pbuilder/4368/var/run': Directory not empty
rmdir: failed to remove `/var/build/temp/tmp.We45OjFEEs/pbuilder/4368/var': Directory not empty
rmdir: failed to remove `/var/build/temp/tmp.We45OjFEEs/pbuilder/4368': Directory not empty
--> pbuilder failed!
Comment 3 Florian Best univentionstaff 2014-09-10 09:18:10 CEST
(In reply to Alexander Kramer from comment #2)
From the logfiles:
The following packages have unmet dependencies:
 pbuilder-satisfydepends-dummy : Depends: npm which is a virtual package.

Probably npm has to be built first!
Comment 4 Alexander Kramer univentionstaff 2014-09-10 13:39:08 CEST
Successful build
Package: stylus
Version: 0.0.0-9.10.201409101306
Branch: ucs_4.0-0

r53535 Adapted the link for more information
http://stackoverflow.com/questions/22099098/npm-self-signed-cert-in-chain-on-azure
r53532 Added a workaround to prevent “SELF_SIGNED_CERT_IN_CHAIN” error
r53515 Adapted some copyright information
r53515 use cp -r instead of mv in the Makefile
Comment 5 Alexander Kramer univentionstaff 2014-09-10 14:09:56 CEST
I installed the package from omar, stylus -h works fine.
Comment 6 Florian Best univentionstaff 2014-09-10 14:16:24 CEST
stylus does not need to depend on npm. npm is only required as build dependency.
Comment 7 Alexander Kläser univentionstaff 2014-09-10 16:13:09 CEST
Please make the following adjustments:
* Replace the wrapper script bin/stylus with a symbolic link to /usr/share/node-stylus/bin/stylus
* Remove the folder node-stylus from the SVN
* User a fixed version number in the Makefile:
  npm install stylus@VERSION → will install a specific version AFAIK
  npm view stylus versions   → shows all available versions
Comment 8 Alexander Kramer univentionstaff 2014-09-11 09:52:27 CEST
r 53591 Adapted the .install and .postint files
r 5390 Removed directories and dependency,
added symlink and version number

Successful build
Package: stylus
Version: 0.0.0-11.12.201409110947
Branch: ucs_4.0-0
Comment 9 Alexander Kramer univentionstaff 2014-09-11 09:57:56 CEST
Tested the package from omar, works fine. even the deinstallation removed the symlink.
Comment 10 Alexander Kläser univentionstaff 2014-10-06 18:24:05 CEST
Please replace the postinst script with a debian/stylus.links file, as currently, the symlink will persist when removing the package.

I adapted the version number to reflect the upstream version.
Comment 11 Stefan Gohmann univentionstaff 2014-10-19 19:52:47 CEST
Move all unfinished MS1 and MS2 bugs to RC.
Comment 12 Alexander Kramer univentionstaff 2014-10-28 09:04:00 CET
r54994
As requested I replace the .postint with a .link-file.
Now the symlink will be removed with the package - tested it on my vm.

Package: stylus
Version: 0.48.1-2.15.201410280851
Branch: ucs_4.0-0
Comment 13 Alexander Kläser univentionstaff 2014-11-04 16:57:57 CET
Everything looks good → VERIFIED
Changelog not required as this is only a package needed as build dependency for UMC.
Comment 14 Stefan Gohmann univentionstaff 2014-11-26 06:55:06 CET
UCS 4.0-0 has been released:
 http://docs.univention.de/release-notes-4.0-0-en.html
 http://docs.univention.de/release-notes-4.0-0-de.html

If this error occurs again, please use "Clone This Bug".