Bug 36321 - Radio button in ad connection wizard
Radio button in ad connection wizard
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0
Assigned To: Alexander Kramer
Florian Best
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-27 20:46 CET by Stefan Gohmann
Modified: 2014-11-26 06:55 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
umc-adconnection-wizard.png (151.55 KB, image/png)
2014-10-27 20:46 CET, Stefan Gohmann
Details
radio buttons.patch (916 bytes, patch)
2014-11-03 12:29 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2014-10-27 20:46:54 CET
Created attachment 6245 [details]
umc-adconnection-wizard.png

The text is below the radio buttons, see attached screenshot. The text should be next to the radio buttons.
Comment 1 Alexander Kramer univentionstaff 2014-10-28 12:47:37 CET
r55014:
moved label next to radio buttons

checked it on my local vm

Package: univention-ad-connector
Version: 9.0.8-1.454.201410281235
Branch: ucs_4.0-0
Comment 2 Florian Best univentionstaff 2014-11-03 12:29:35 CET
Created attachment 6281 [details]
radio buttons.patch

OK, the fix works!
Maybe it is better to instead inherit from our own RadioButton class instead of the dojo/dijit one. The class didn't exists at that moment when the adconnection wizard was written. But VERIFIED because i don't know if it would have side effects. (@alex kläser)
Comment 3 Alexander Kläser univentionstaff 2014-11-03 15:36:40 CET
(In reply to Florian Best from comment #2)
> ...
> Maybe it is better to instead inherit from our own RadioButton class instead
> of the dojo/dijit one. The class didn't exists at that moment when the
> adconnection wizard was written. But VERIFIED because i don't know if it
> would have side effects. (@alex kläser)

No, the RadioButtons here have different behaviour, as you can set a list of id-label pairs (via the property staticValues) which will be displayed with a list of radio buttons. The class umc/widget/RadioButton (without the plural "s") represents only one RadioButton which is more flexible for layouting.
Comment 4 Stefan Gohmann univentionstaff 2014-11-26 06:55:46 CET
UCS 4.0-0 has been released:
 http://docs.univention.de/release-notes-4.0-0-en.html
 http://docs.univention.de/release-notes-4.0-0-de.html

If this error occurs again, please use "Clone This Bug".