Univention Bugzilla – Bug 36581
"Invalid smb.conf" output by testparm
Last modified: 2015-10-28 13:22:53 CET
The samba configuration parser has been reworked and now it seems to dislike the way we include files: This is what samba-tool testparm thinks about a standard smb.conf with one share and two printers, included as usual via shares.conf/shares.conf.d and printers.conf/printers.conf.d : ========================================================== [print$] comment = Printer Drivers path = /var/lib/samba/drivers write list = root Administrator @Printer-Admins read only = No include = /etc/samba/shares.conf.d/share1dcs [share1dcs] path = /share1dcs valid users = @group2 read only = No inherit acls = Yes include = /etc/samba/printers.conf.d/printer2dcs vfs objects = acl_xattr msdfs root = Yes [printer2dcs] path = /tmp guest ok = Yes printable = Yes print ok = Yes printer name = printer2dcs force printername = Yes include = /etc/samba/printers.conf.d/printer1dcs [printer1dcs] path = /tmp guest ok = Yes printable = Yes print ok = Yes printer name = printer1dcs force printername = Yes ERROR: Invalid smb.conf ========================================================== We should check if this can be improved to avoid unexpected behaviour of samba components.
Looks like this is the issue: winbind separator = + And this is where it comes from in python/samba/netcmd/testparm.py: if winbind_separator == '+': logger.error( "'winbind separator = +' might cause problems with group " "membership.") valid = False So we have three options: a) ignore the message b) patch the code c) change the parameter value (e.g. make it adjustable via UCR).
(In reply to Arvid Requate from comment #1) > Looks like this is the issue: > > winbind separator = + > > And this is where it comes from in python/samba/netcmd/testparm.py: > > if winbind_separator == '+': > logger.error( > "'winbind separator = +' might cause problems with group " > "membership.") > valid = False > > So we have three options: > > a) ignore the message > b) patch the code > c) change the parameter value (e.g. make it adjustable via UCR). I vote for c).
This is a minor issue, I think it's not worth changing the winbind separator now. I patched python/samba/netcmd/testparm.py instead, to issue a warning instead of an error. I guess this might even get accepted upstream. Changelog adjusted.
Ah, this is errata4.0-3, so I've merged the patch from 4.1 to errata4.0-3 and rebuilt samba there as well. I removed the UCS 4.1 changelog and added a yaml advisory instead.
OK - errata4-0-3 OK - 4.1-0 OK - YAML
<http://errata.software-univention.de/ucs/4.0/346.html>