Bug 38545 - [Performance] App Center overview
[Performance] App Center overview
Status: CLOSED FIXED
Product: UCS Test
Classification: Unclassified
Component: App Center
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: Jürn Brodersen
Alexander Kläser
:
Depends on: 39632 40239 40240
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-15 07:12 CEST by Stefan Gohmann
Modified: 2023-03-25 06:42 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2015-05-15 07:12:20 CEST
We should add performance tests for the UMC App Center modul. I think the UMC App Center overview should be available after five seconds. A second request should be much faster.
Comment 1 Jürn Brodersen univentionstaff 2015-11-03 12:15:19 CET
I added a performance test for the UMC App Center. The current timeout after which the test fails is set to 5 sec.

UCS4.1-0:
r65118: * Added performance test for the appcenter (Bug #38545)
Package: ucs-test
Version: 6.0.12-11.1316.201511031208
Comment 2 Alexander Kläser univentionstaff 2015-11-04 17:25:00 CET
Superb :) ! As the test currently fails, it would be nice to mark the test case as known such that the test will not be executed at the moment. Please create a new bug which states that the performance for the query command needs to be improved.
Comment 3 Jürn Brodersen univentionstaff 2015-11-05 13:57:20 CET
UCS4.1-0:
r65232: * Set 20_appcenter/60_check_appcenter_performance to SKIP
          (Bug #38545; #39632)
Package: ucs-test
Version: 6.0.13-2.1322.201511051351
Comment 4 Alexander Kläser univentionstaff 2016-02-03 17:25:25 CET
Current results are as follows... not sure whether the test should be re-activated. The first round probably syncs app center data.

@Dirk: What do you think?

> root@ucs-dc-4621:~# /usr/share/ucs-test/20_appcenter/60_check_appcenter_performance
> ### FAIL ###
> The appcenter answered too slow
> Threshold is 5 sec; Appcenter replied in 12.5546138287 sec.
> ###      ###
> Starting 1 ucs-test at 2015-12-22 04:35:09 to /dev/null
> Check the performance for requests against the UMC appcenter..................................................................... Test failed
>
> root@ucs-dc-4621:~# /usr/share/ucs-test/20_appcenter/60_check_appcenter_performance
> Starting 1 ucs-test at 2015-12-22 04:35:20 to /dev/null
> Check the performance for requests against the UMC appcenter..................................................................... Test passed
>
> root@ucs-dc-4621:~# /usr/share/ucs-test/20_appcenter/60_check_appcenter_performance
> Starting 1 ucs-test at 2015-12-22 04:35:35 to /dev/null
> Check the performance for requests against the UMC appcenter..................................................................... Test passed
Comment 5 Jürn Brodersen univentionstaff 2016-02-05 11:47:04 CET
I could change the test to ignore the first app center call. But I think a long loading time for the first app center start could give a bad first impression.

Would it be possible to sync the app center data as part of the system-setup or with a cron job?
Comment 6 Alexander Kläser univentionstaff 2016-02-16 10:22:36 CET
(In reply to Jürn Brodersen from comment #5)
> I could change the test to ignore the first app center call. But I think a
> long loading time for the first app center start could give a bad first
> impression.
> 
> Would it be possible to sync the app center data as part of the system-setup
> or with a cron job?

See Bug 39632, comment #10:
> (In reply to Alexander Kläser from comment #9)
> > I think a cron job would be nice to avoid syncing the data which leads to
> > bad performance with the first request.
> 
> Actually, there is a cron job that does that, though not directly
> univention-app update.
> 
> But it is called as part of univention-upgrade which runs once a day.

What about calling univention-app update before running the test? This should be a fair performance test then. IMHO it cannot really be forseen how long the synchronization of the App Center data will take.
Comment 7 Jürn Brodersen univentionstaff 2016-03-14 15:19:09 CET
The app center is now updated before the request is made.
UCS4.1-0:
r68072: * 20_appcenter/60_check_appcenter_performance: Update Appcenter before
testing the appcenter performance
Package: ucs-test
Version: 6.0.33-42.1448.201603141510
Comment 8 Alexander Kläser univentionstaff 2016-03-15 16:24:41 CET
OK for now.
Comment 9 Stefan Gohmann univentionstaff 2017-02-21 07:49:59 CET
The test case fails from time to time:

http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-4/job/AutotestJoin/SambaVersion=s3,Systemrolle=member/111/testReport/20_appcenter/60_check_appcenter_performance/test/

[2017-02-20 21:36:43.714607] Appcenter update starting
[2017-02-20 21:36:52.773051] Appcenter update done
[2017-02-20 21:36:52.775495] Getting umc_connection
[2017-02-20 21:36:53.126296] Start request to appcenter
[2017-02-20 21:37:05.261161] Request finished
[2017-02-20 21:37:05.261288] ### FAIL ###
[2017-02-20 21:37:05.261332] The appcenter answered too slow
[2017-02-20 21:37:05.261348] Threshold is 4.5 sec; Appcenter replied in 4.58675909042 sec.
[2017-02-20 21:37:05.261380] ###      ###
Comment 10 Jürn Brodersen univentionstaff 2017-02-21 09:25:03 CET
Should I change the timeout or deactivate the test?
Comment 11 Alexander Kläser univentionstaff 2017-02-21 11:15:56 CET
(In reply to Jürn Brodersen from comment #10)
> Should I change the timeout or deactivate the test?

I would suggest to change the timeout to 5sec (or a bit higher) then, although I would consider this behaviour to be a bug. 5sec really is too slow.
Comment 12 Stefan Gohmann univentionstaff 2017-02-24 06:27:17 CET
(In reply to Alexander Kläser from comment #11)
> (In reply to Jürn Brodersen from comment #10)
> > Should I change the timeout or deactivate the test?
> 
> I would suggest to change the timeout to 5sec (or a bit higher) then,
> although I would consider this behaviour to be a bug. 5sec really is too
> slow.

Yes, let's try 5 seconds and yes I also think it is too slow.
Comment 13 Dirk Wiesenthal univentionstaff 2017-02-24 08:31:16 CET
I am working on App Setting. This may speedup the process, maybe we can keep up the threshold.
Comment 14 Jürn Brodersen univentionstaff 2017-02-24 10:05:43 CET
r77089: 20_appcenter/60_check_appcenter_performance: increase timeout
Package: ucs-test
Version: 6.0.37-56.1598.201702240948
Branch: ucs_4.1-0
Scope: errata4.1-4

I increased the timeout for now.
Comment 15 Alexander Kläser univentionstaff 2017-08-09 14:46:26 CEST
(In reply to Dirk Wiesenthal from comment #13)
> I am working on App Setting. This may speedup the process, maybe we can keep
> up the threshold.

In the meantime, the threshold was set to 15 sec. 

From one of the last runs:
> Success: The appcenter answered in 8.87774896622 sec.

@Dirk: This really is not acceptable!

Nevertheless, this bug can be set to VERIFIED.