Bug 38563 - Samba4 doesn't reopen its logfiles after postrotate kill
Samba4 doesn't reopen its logfiles after postrotate kill
Status: CLOSED WORKSFORME
Product: UCS
Classification: Unclassified
Component: Samba4
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.3-2-errata
Assigned To: Felix Botner
Arvid Requate
:
Depends on:
Blocks: 37159 37316 37317 38143
  Show dependency treegraph
 
Reported: 2015-05-19 13:40 CEST by Florian Best
Modified: 2021-03-19 12:23 CET (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.154
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2016041921000399
Bug group (optional): Troubleshooting
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2015-05-19 13:40:36 CEST
REOPEN: The logfile log.samba is not reopened by samba4.

root@master:/etc/logrotate.d# lsof  | grep /var/log/samba/log.samba.1
samba 13288 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13288 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13289 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13289 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13290 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13290 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13291 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13291 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13292 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13292 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
smbd  13293 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13294 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13294 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13295 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13295 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13296 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13296 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13297 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13297 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13298 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13298 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13299 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13299 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
smbd  13309 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
root@master:/etc/logrotate.d# /usr/bin/killall -HUP -i /usr/sbin/samba
Signal samba(13275) senden? (y/N) y
Signal samba(13288) senden? (y/N) y
Signal samba(13289) senden? (y/N) y
Signal samba(13290) senden? (y/N) y
Signal samba(13291) senden? (y/N) y
Signal samba(13292) senden? (y/N) y
Signal samba(13294) senden? (y/N) y
Signal samba(13295) senden? (y/N) y
Signal samba(13296) senden? (y/N) y
Signal samba(13297) senden? (y/N) y
Signal samba(13298) senden? (y/N) y
Signal samba(13299) senden? (y/N) y
root@master:/etc/logrotate.d# lsof  | grep /var/log/samba/log.samba.1
samba 13288 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13288 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13289 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13289 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13290 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13290 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13291 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13291 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13292 root 2w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
samba 13292 root 3w REG 253,0 4255 2108662 /var/log/samba/log.samba.1 (deleted)
[...]

+++ This bug was initially created as a clone of Bug #36473 +++

logrotate does not trigger the running applications to reopen their logfiles. Thus they are still logging into already deleted files and the log entries are lost.

root@master:~# lsof | grep .log.1
apache2    1445   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2    1629   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2    5946   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2    5947   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2    6637   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
squid3     8153       root    3u      REG              253,0     18665     399352 /var/log/squid3/cache.log.1 (deleted)
squid3     8156      proxy    3u      REG              253,0     18665     399352 /var/log/squid3/cache.log.1 (deleted)
univentio 11056       root    4u      REG              253,0     37070     400458 /var/log/univention/management-console-web-server.log.1 (deleted)
apache2   11104       root    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2   18150   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2   18157   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2   20148   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2   23107   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
apache2   31323   www-data    3u      REG              253,0      1069     400448 /var/log/univention/management-console-module-lib.log.1 (deleted)
Comment 1 Arvid Requate univentionstaff 2015-05-19 14:46:42 CEST
Looks like the HUP signal sent by logrotate has not the desired effect on samba:

======= /etc/logrotate.d/univention-samba4 =========
/var/log/samba/log.samba {
        weekly
        rotate 12
        create 640 root adm
        compress
        missingok
        notifempty
        postrotate
                /usr/bin/killall -HUP /usr/sbin/samba
        endscript
}
====================================================
Comment 2 Arvid Requate univentionstaff 2016-04-20 14:31:02 CEST
Reported again at Ticket#: 2016041921000399:

smbd 11249 root 4w REG 254,0 267826411 40703 /var/log/samba/log.samba.1 (deleted)
Comment 3 Felix Botner univentionstaff 2018-11-27 11:33:40 CET
-> ucr set samba/debug/level='10' 
-> /etc/init.d/samba restart

-> logrotate -f /etc/logrotate.d/univention-samba4 

-> tail -f /var/log/samba/log.samba
-> univention-s4search 

=> lots of output in tail ...