Bug 38686 - Improve Checks in Samba Initscript
Improve Checks in Samba Initscript
Product: UCS
Classification: Unclassified
Component: Samba4
UCS 4.2
Other Linux
: P5 normal (vote)
: ---
Assigned To: Samba maintainers
Samba maintainers
Depends on:
  Show dependency treegraph
Reported: 2015-06-11 13:37 CEST by Tim Petersen
Modified: 2020-07-03 20:51 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2017021021000308
Bug group (optional): Error handling, External feedback
Max CVSS v3 score:
requate: Patch_Available+

1.patch (881 bytes, patch)
2017-02-21 12:43 CET, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Petersen univentionstaff 2015-06-11 13:37:59 CEST
The current samba init-script samba-ad-dc uses testparm to confirm wether its a domaincontroller:

SERVER_ROLE=`samba-tool testparm --parameter-name="server role"  2>/dev/null | tail -1`
                if [ "$SERVER_ROLE" != "active directory domain controller" ]; then
                    echo "Samba is not configured as AD DC."
                    exit 0

The check potentially fails udner various circumstances where samba could be started without any problem.
For example if there are problems with specific share configurations.

As a result the samba domaincontroller completey loses its functionaluty instead of just having minor issues with _one share.

The check should be improved/changed
Comment 1 Arvid Requate univentionstaff 2015-06-11 18:16:21 CEST
Yeah, this sucks, I agree. We should think about a better way and push a patch to the Debian packaging team. Let's bear in mind that all this restructuring of samba+smbd+nmbd from one source package is fairly new. If you have more recommendations for improvement here don't hesitate to bring the forward.
Comment 2 Christina Scheinig univentionstaff 2017-02-21 09:36:50 CET
In Ticket# 2017021021000308 we had a share configured with double spaces. In this case the UMC should not allow this.
Comment 3 Arvid Requate univentionstaff 2017-02-21 11:39:51 CET
I've moved Comment 2 to the more specific Bug 38688.
Comment 4 Arvid Requate univentionstaff 2017-02-21 12:43:40 CET
Created attachment 8442 [details]

This patch improves the error handling.
Comment 5 Ingo Steuwer univentionstaff 2020-07-03 20:51:57 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.