Bug 38756 - univention-join should forcefully kill notifier and listener
univention-join should forcefully kill notifier and listener
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Join (univention-join)
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.0-3-errata
Assigned To: Philipp Hahn
Alexander Kramer
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-23 14:39 CEST by Janis Meybohm
Modified: 2015-09-09 12:51 CEST (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janis Meybohm univentionstaff 2015-06-23 14:39:25 CEST
+++ This bug was initially created as a clone of Bug #38754 +++

Ticket#2015052021000181

univention-join contains two loops to stop the notifier and the listener. Both may run infinitely if the services don't stop for some reason (e.g listener in initialization phase).

I think it should be okay to forcefully stop both services if they don't respond to 1+n "stop-tries". There is nothing that could break because listener cache and status as well as the LDAP DB is removed during join.
Comment 1 Tim Petersen univentionstaff 2015-07-30 11:07:32 CEST
Yes, please - happend again: 2015072021000276
Comment 2 Tim Petersen univentionstaff 2015-07-30 11:43:00 CEST
We should improve the behaviour via erratum. It occurs often in various scenarios and this would be the generix "fix".


(In reply to Janis Meybohm from comment #0)
> I think it should be okay to forcefully stop both services if they don't
> respond to 1+n "stop-tries". There is nothing that could break because
> listener cache and status as well as the LDAP DB is removed during join.

Full assent
Comment 3 Philipp Hahn univentionstaff 2015-08-21 08:18:09 CEST
r63149 | Bug #38756 Join: Force kill UDN und UDL
r63148 | Bug #38756 Join: Force kill UDN und UDL
 sv force-stop univention-directory-{listener,notifier}

Package: univention-join
Version: 7.1.2-16.507.201508210810
Branch: ucs_4.0-0
Scope: errata4.0-3

Package: univention-join
Version: 8.0.0-2.506.201508210809
Branch: ucs_4.1-0

r63150 | Bug #38756 Join: Force kill UDN und UDL YAML
 2015-08-21-univention-join.yaml
Comment 4 Alexander Kramer univentionstaff 2015-09-07 14:34:50 CEST
I rejoined a slave after stopping the listener and manually extended /var/lib/univention-ldap/notify/transaction

OK - forcefully kill notifier and listener

UCS4.0-3
OK - debian/changelog
OK - yaml file

UCS4.1-0
OK - debian/changelog
FYI - no xml changelog necessary
Comment 5 Janek Walkenhorst univentionstaff 2015-09-09 12:51:11 CEST
<http://errata.software-univention.de/ucs/4.0/304.html>