Bug 38891 - App Rating
App Rating
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.1
Other Linux
: P5 enhancement (vote)
: UCS 4.1
Assigned To: Dirk Wiesenthal
Stefan Gohmann
: interim-2
Depends on:
Blocks: 39846
  Show dependency treegraph
 
Reported: 2015-07-10 13:55 CEST by Stefan Gohmann
Modified: 2015-11-17 12:12 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Release Goal
Max CVSS v3 score:


Attachments
Sketch (26.15 KB, image/png)
2015-11-03 10:42 CET, Alexander Kläser
Details
Patch for icons.styl in umc-theme (711 bytes, patch)
2015-11-03 10:44 CET, Alexander Kläser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2015-07-10 13:55:37 CEST
It should be possible to define premium apps which are presented more prominent.
Comment 1 Dirk Wiesenthal univentionstaff 2015-10-27 18:37:30 CET
Backend works: .meta file is found and parsed. rating.ini is downloaded, rating attribute is sent to frontend

Frontend not finished: Rating is shown but no icons. Probably some padding issues, too.

univention-appcenter 5.0.9-4.23.201510271835
Comment 2 Dirk Wiesenthal univentionstaff 2015-10-27 20:58:19 CET
owncloud8-docker has an example rating
Comment 3 Dirk Wiesenthal univentionstaff 2015-10-29 00:00:20 CET
New positioning in
  univention-appcenter (5.0.9-8)
Comment 4 Dirk Wiesenthal univentionstaff 2015-10-30 17:28:42 CET
Fixed in
  univention-appcenter 5.0.13-5.37.201510301725

owncloud8-docker has an example rating
Comment 5 Dirk Wiesenthal univentionstaff 2015-11-03 01:14:46 CET
Wording / layout fixes in
  univention-appcenter 5.0.14-11.49.201511030106
Comment 6 Alexander Kläser univentionstaff 2015-11-03 10:42:50 CET
Created attachment 7243 [details]
Sketch

I like the adjusted layout for the app rating. Attached a sketch with some more minor adjustments:
* Change h3 → h1 and align both h1 elements next to each other.
* Use the small help icon (12px x 12px) from icons-small.
* Use hover styling similar to other icons.
Comment 7 Alexander Kläser univentionstaff 2015-11-03 10:44:00 CET
Created attachment 7244 [details]
Patch for icons.styl in umc-theme

Find attached the corresponding CSS/stylus rules for the CSS class umcHelpIconSmall.
Comment 8 Dirk Wiesenthal univentionstaff 2015-11-03 14:54:00 CET
Fixed in
  univention-management-console-frontend-theme 1.0.1-6.107.201511031357
  univention-appcenter 5.0.14-14.51.201511031449
Comment 9 Stefan Gohmann univentionstaff 2015-11-04 09:31:17 CET
It looks good now. Please add a changelog entry.
Comment 10 Dirk Wiesenthal univentionstaff 2015-11-04 15:42:33 CET
Changelog added
Comment 11 Alexander Kläser univentionstaff 2015-11-04 15:47:43 CET
Can you please add a bit more margin to the .mainHeader CSS rule:

.umc .umcAppDetailsPage .mainHeader {
    /* ... */
    margin-bottom: 0.8em;
}
Comment 12 Dirk Wiesenthal univentionstaff 2015-11-04 22:37:46 CET
OK

univention-appcenter 5.0.15-3.54.201511042230
Comment 13 Stefan Gohmann univentionstaff 2015-11-05 06:24:20 CET
OK
Comment 14 Stefan Gohmann univentionstaff 2015-11-17 12:12:49 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".