Bug 38934 - renaming a SAML service provider doesn't update the user references
renaming a SAML service provider doesn't update the user references
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: SAML
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.1
Assigned To: Florian Best
Erik Damrose
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-16 13:15 CEST by Florian Best
Modified: 2015-11-17 12:12 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2015-07-16 13:15:46 CEST
If a user is allowed to use the identity provider 'foo' and foo gets renamed to bar the user still only have the permissions for the not-anymore-existing 'foo' and not for 'bar'.

We should prevent a rename.
diff --git a/component/saml/univention-saml/modules/univention/admin/handlers/saml/serviceprovider.py b/component/saml/univention-saml/modules/univention/admin/handlers/saml/serviceprovider.py
index 6ec16b9..db5f1c0 100644
--- a/component/saml/univention-saml/modules/univention/admin/handlers/saml/serviceprovider.py
+++ b/component/saml/univention-saml/modules/univention/admin/handlers/saml/serviceprovider.py
@@ -63,7 +63,7 @@
                        multivalue = False,
                        options = [],
                        required = True,
-                       may_change = True,
+                       may_change = False,
                        identifies = True,
                ),
        'AssertionConsumerService': univention.admin.property(
Comment 1 Florian Best univentionstaff 2015-07-23 12:26:47 CEST
I moved the package univention-saml from components into services/.

Package: univention-saml
Version: 3.0.0-1.30.201507231223
Branch: ucs_4.1-0
Comment 2 Erik Damrose univentionstaff 2015-09-28 16:03:49 CEST
Probably the best solution, as a rename would also change URLs etc.

OK: r62351 
OK: Changelog
Comment 3 Stefan Gohmann univentionstaff 2015-11-17 12:12:22 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".