Bug 39374 - Every app needs to specify DockerImage, no default image allowed; may specify list of DockerAllowedImages
Every app needs to specify DockerImage, no default image allowed; may specify...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UNSTABLE
Other Linux
: P5 normal (vote)
: UCS 4.1
Assigned To: Dirk Wiesenthal
Stefan Gohmann
: interim-2
Depends on: 39204 39448
Blocks: 38887
  Show dependency treegraph
 
Reported: 2015-09-21 15:18 CEST by Dirk Wiesenthal
Modified: 2015-11-17 12:11 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2015-09-21 15:18:52 CEST
This makes it possible to set a new image (like 4.2-0) in a new version of the app after the initial version had (4.1-0).

Without this, every app would either require new app installations to go through a lot of release updates after installation or exchange images for no good reason.

DockerAllowedImages should be taken into account when searching for updates. If the old DockerImage is in the new DockerAllowedImages, no image upgrade is to be performed. New installations should take DockerImage.
Comment 1 Stefan Gohmann univentionstaff 2015-09-23 08:18:53 CEST
This seems to break the current docker app installation.

If I try to install one of both docker test apps, the app center tries to install the app into the system and not into the docker container.
Comment 2 Dirk Wiesenthal univentionstaff 2015-09-23 11:20:55 CEST
Fixed in
  univention-management-console-module-appcenter 5.0.5-2.441.201509231115
Comment 3 Stefan Gohmann univentionstaff 2015-09-29 07:28:49 CEST
If I create an App without DockerImage, the App installation fails which is correct, but the packages are temporarily installed in the local system. See test case 80_docker/53_missing_dockerimage.
Comment 4 Stefan Gohmann univentionstaff 2015-09-29 09:31:11 CEST
(In reply to Stefan Gohmann from comment #3)
> If I create an App without DockerImage, the App installation fails which is
> correct, but the packages are temporarily installed in the local system. See
> test case 80_docker/53_missing_dockerimage.

OK, as discussed with Dirk. The Docker=True parameter has been removed. If DockerImage is missing, the App is installed into the local system. The test case have been adjusted.

Please remove Docker=True from the App tutorial.
Comment 5 Dirk Wiesenthal univentionstaff 2015-09-29 09:32:47 CEST
(In reply to Stefan Gohmann from comment #4)
> Please remove Docker=True from the App tutorial.

Done. r64063
Comment 6 Stefan Gohmann univentionstaff 2015-10-01 07:10:46 CEST
I've added a test case for this: 80_docker/65_app_container_upgrade_dockerallowedimage

The container upgrade doesn't work, so we have to move the final QA for this to interim-2. The container upgrade issue: Bug #39204

In addition, the upgrade in a container currently failed: Bug #39448.
Comment 7 Stefan Gohmann univentionstaff 2015-10-18 20:08:11 CEST
Can you give an example for DockerAllowedImages?

I tried a comma and a space separated list. Both tests were not successful.

See 80_docker/65_app_container_upgrade_dockerallowedimage
Comment 8 Dirk Wiesenthal univentionstaff 2015-10-19 04:40:55 CEST
(In reply to Stefan Gohmann from comment #7)
> Can you give an example for DockerAllowedImages?
> 
> I tried a comma and a space separated list. Both tests were not successful.
> 
> See 80_docker/65_app_container_upgrade_dockerallowedimage

Fixed in
  univention-management-console-module-appcenter 5.0.6-29.476.201510190439
Comment 9 Stefan Gohmann univentionstaff 2015-10-19 06:03:00 CEST
(In reply to Dirk Wiesenthal from comment #8)
> Fixed in
>   univention-management-console-module-appcenter 5.0.6-29.476.201510190439

OK, it works now, see 80_docker/65_app_container_upgrade_dockerallowedimage:

DockerAllowedImages='docker.software-univention.de/nonexisting-image1,docker.software-univention.de/ucs-appbox-amd64:4.0-3,docker.software-univention.de/nonexisting-image1'
Comment 10 Stefan Gohmann univentionstaff 2015-11-17 12:11:52 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".