Bug 39585 - Rename source package univention-management-console-module-appcenter
Rename source package univention-management-console-module-appcenter
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1
Assigned To: Philipp Hahn
Dirk Wiesenthal
: interim-2
Depends on:
Blocks: 39306
  Show dependency treegraph
 
Reported: 2015-10-19 10:07 CEST by Dirk Wiesenthal
Modified: 2015-11-17 12:12 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2015-10-19 10:07:48 CEST
The source directory of univention-management-console-module-appcenter contains two UMC modules, some UDM integration, the univention.appcenter lib.

Rename the source package to univention-appcenter. Do not touch the binary package names.
Comment 1 Dirk Wiesenthal univentionstaff 2015-10-22 13:04:04 CEST
Fixed in
  univention-appcenter 5.0.6-55.1.201510221245
Comment 2 Philipp Hahn univentionstaff 2015-10-23 17:14:20 CEST
Update breaks due to broken packaging (Bug #39306 comment 8):
    $ dpkg-buildpackage -uc -us -b
    ...
    > dpkg-gencontrol: warning: package univention-management-console-module-appcenter: unused substitution variable ${python:Versions}
    > dpkg-gencontrol: warning: package univention-management-console-module-appcenter: unused substitution variable ${python:Depends}
    > dpkg-gencontrol: warning: package univention-appcenter: unused substitution variable ${python:Depends}
    > dpkg-gencontrol: warning: package python-univention-appcenter: unused substitution variable ${python:Versions}
    > dpkg-gencontrol: warning: package python-univention-appcenter: unused substitution variable ${python:Provides}
    > dpkg-gencontrol: warning: package python-univention-appcenter: unused substitution variable ${misc:Depends}
    > dpkg-gencontrol: warning: package python-univention-appcenter: unused substitution variable ${python:Depends}
    > dpkg-gencontrol: warning: package univention-appcenter-dev: unused substitution variable ${python:Versions}
    > dpkg-gencontrol: warning: package univention-appcenter-dev: unused substitution variable ${python:Depends}
    > dpkg-gencontrol: warning: package univention-appcenter-docker: unused substitution variable ${python:Versions}
    > dpkg-gencontrol: warning: package univention-appcenter-docker: unused substitution variable ${misc:Depends}
    > dpkg-gencontrol: warning: package univention-appcenter-docker: unused substitution variable ${python:Depends}
    > dpkg-gencontrol: warning: package univention-management-console-module-apps: unused substitution variable ${python:Versions}
    > dpkg-gencontrol: warning: package univention-management-console-module-apps: unused substitution variable ${misc:Depends}
    > dpkg-gencontrol: warning: package univention-management-console-module-apps: unused substitution variable ${python:Depends}
    
    $ ucslint
    E:0014-5: debian/python-univention-appcenter.postinst: Missing Depends: univention-config, ${misc:Depends}
    E:0014-5: debian/univention-appcenter-docker.postinst: Missing Depends: univention-config, ${misc:Depends}
    W:0011-11: debian/control: XS-Python-Version is not required any longer
    E:0008-1: umc/python/appcenter/__init__.py:308: substitutes before translation: _('%s: Running tests' % app.name)
    E:0008-1: umc/python/appcenter/__init__.py:327: substitutes before translation: _('Installing %s' % app.name)
    E:0008-1: umc/python/appcenter/__init__.py:330: substitutes before translation: _('Uninstalling %s' % app.name)
    E:0008-1: umc/python/appcenter/__init__.py:333: substitutes before translation: _('Upgrading %s' % app.name)
    E:0008-3: umc/python/appcenter/de.po:50: contains "fuzzy"
    W:0008-4: umc/python/appcenter/de.po:27: contains empty msgstr
    W:0008-4: umc/python/appcenter/de.po:85: contains empty msgstr
    W:0008-4: umc/python/appcenter/de.po:125: contains empty msgstr
    W:0008-4: umc/python/appcenter/de.po:130: contains empty msgstr
    E:0006-6: debian/univention-appcenter-docker.postinst: script contains no "exit 0" at end of file
    E:0006-6: debian/python-univention-appcenter.postinst: script contains no "exit 0" at end of file
    S:0004-24: debian/univention-appcenter-docker.univention-config-registry-variables: univention-appcenter-docker.univention-config-registry exists but corresponding ./debian/univention-appcenter-docker.univention-config-registry-variables is missing
    S:0004-24: debian/univention-management-console-module-apps.univention-config-registry-variables: univention-management-console-module-apps.univention-config-registry exists but corresponding ./debian/univention-management-console-module-apps.univention-config-registry-variables is missing
    W:0004-10: debian/univention-appcenter-docker.univention-config-registry: file contains subfile entry without corresponding multifile entry.
          - subfile = etc/apache2/sites-available/default.d/10univention-appcenter
          - multifile = etc/apache2/sites-available/default
    W:0004-10: debian/univention-appcenter-docker.univention-config-registry: file contains subfile entry without corresponding multifile entry.
          - subfile = etc/apache2/sites-available/ssl.d/10univention-appcenter
          - multifile = etc/apache2/sites-available/default-ssl
    W:0004-16: conffiles/usr/share/univention-management-console/i18n/de/apps.mo: UCR header is missing
    W:0004-18: debian/univention-appcenter-docker.univention-config-registry: UCR header is maybe missing in multifile "etc/apache2/sites-available/default"
    W:0004-18: debian/univention-appcenter-docker.univention-config-registry: UCR header is maybe missing in multifile "etc/apache2/sites-available/default-ssl"

r64812 | Bug #39585 App: Fix univention-appcenter packaging
    - debian/control: Fix short descriptions
    - debian/control: Add missing ${*:Depends}
    - debian/control: Add missing Build-Depends: ucslint
    - debian/rules: Add missing call to ucslint
    - debian/ucslint.overrides: Added
    - debian/*.postinst: Add "exit 0"
    - debian/*.postinst: Explicitly link Python modules
    - umc/python/appcenter/__init__.py: Fix translation errors
    - umc/python/appcenter/__init__.py: Fix use of invoke-rc.d
    - umc/python/appcenter/de.po: Add missing translation
    
    Update translations.
    
    Change http://docs.univention.de/ to https://docs.software-univention.de/
    
FYI: Don't tell Admins to use "invoke-rc.d": that tools MUST be used in debian/*.{pre,post}{inst,rm} scripts to follow an installed "policy-rc.d" layer. That is irrelevant for interactive use and would prevent an Admin from manually starting/stopping/restarting the service; she should use "service $service $action" instead or invoke the init.d script directly.
Comment 3 Philipp Hahn univentionstaff 2015-10-23 17:17:17 CEST
Package: univention-appcenter
Version: 5.0.6-70.15.201510231710
Branch: ucs_4.1-0
Comment 4 Stefan Gohmann univentionstaff 2015-10-31 21:03:33 CET
Changelog entry is OK and the rename as well → first part is verified.

@Dirk, please make the QA of r64812.
Comment 5 Dirk Wiesenthal univentionstaff 2015-11-02 13:32:38 CET
r64812 looks good
Comment 6 Stefan Gohmann univentionstaff 2015-11-17 12:12:13 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".