Bug 39654 - Replace the property "screenshot" with "thumbnails"
Replace the property "screenshot" with "thumbnails"
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1
Assigned To: Alexander Kläser
Dirk Wiesenthal
: interim-2
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-28 17:39 CET by Alexander Kläser
Modified: 2015-11-17 12:12 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2015-10-28 17:39:54 CET
The ini-file property "Thumbnails" expects a comma separated list if either screenshot URIs or youtube URIs. This property needs to be implemented in the App Center backend and its value needs to be handed over to the detail page carousel.
Comment 1 Alexander Kläser univentionstaff 2015-10-30 19:37:50 CET
I fixed this, adjusted the ini-files in the meta-inf/4.1 directory, and added some videos from our youtube channel.

However, I am not sure what to do with the parts in the local_appcenter.py:
> ...
> parser.add_argument('-s', '--screenshot', help='Path to a screenshot...')
> ...

@Dirk: Any suggestion?

Changelog:
r65044 | Bug #39654: added changelog entry

univention-appcenter (5.0.14-5):
r65043 | Bug #39654: check JS thumbnails array for length
r65042 | Bug #39654: allow to localize thumbnails
r65041 | Bug #39654: replace screenshot with thumbnails property
Comment 2 Dirk Wiesenthal univentionstaff 2015-11-02 13:05:43 CET
Not sure if this is the bug that introduced it but (deprecated) screenshots are no longer included in the index.json it seems:
  http://appcenter-test.software-univention.de/meta-inf/4.1/filewave/


> However, I am not sure what to do with the parts in the local_appcenter.py:
> > ...
> > parser.add_argument('-s', '--screenshot', help='Path to a screenshot...')
> > ...
> 
> @Dirk: Any suggestion?
> 

Yes. -t, --thumbnails, nargs=+. Copy the args to the filenames specified in the ini file (filter those that begin with http)
Comment 3 Alexander Kläser univentionstaff 2015-11-03 13:31:30 CET
(In reply to Dirk Wiesenthal from comment #2)
> Not sure if this is the bug that introduced it but (deprecated) screenshots
> are no longer included in the index.json it seems:
>   http://appcenter-test.software-univention.de/meta-inf/4.1/filewave/

As discussed, this does not seem to be relevant anymore.

> > However, I am not sure what to do with the parts in the local_appcenter.py:
> > > ...
> > > parser.add_argument('-s', '--screenshot', help='Path to a screenshot...')
> > > ...
> > 
> > @Dirk: Any suggestion?
> > 
> 
> Yes. -t, --thumbnails, nargs=+. Copy the args to the filenames specified in
> the ini file (filter those that begin with http)

I put this in Bug 39726 as there are other changes that have not been adapted, as well.
Comment 4 Dirk Wiesenthal univentionstaff 2015-11-04 17:31:22 CET
OK
Comment 5 Stefan Gohmann univentionstaff 2015-11-17 12:12:01 CET
UCS 4.1 has been released:
 https://docs.software-univention.de/release-notes-4.1-0-en.html
 https://docs.software-univention.de/release-notes-4.1-0-de.html

If this error occurs again, please use "Clone This Bug".