ucs-test scripts for SAML should be added.
UCS4.1-0: r64948: Added tests for SAML SSO Package: ucs-test Version: 6.0.11-1.1303.201510281816
Some tests are failing, can you have a look? Some tests require that there is a DC backup installed. (I don't know how to ensure this): http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-0/job/Autotest%20MultiEnv/84/SambaVersion=s3,Systemrolle=master/testReport/83_saml-sso/06_sso_on_dc_backup/test/ Also the RelayState is not always set in responses, if it is not contained in the form the attribute just shouldn't be set. (SAMLResponse must always exists) http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-0/job/Autotest%20MultiEnv/84/SambaVersion=s3,Systemrolle=master/testReport/83_saml-sso/05_saml_login/test/ http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-0/job/Autotest%20MultiEnv/84/SambaVersion=s3,Systemrolle=master/testReport/83_saml-sso/08_saml_session_ldap_after_restart/test/ Please also set the expiry date more dynamically in 11_saml_user_expire.
Please move thetest cases to the package ucs-test-saml (tests/82_saml/).
AFAIS, the tests are only executed for the S3-Master tests and not even for S4-Master.
*** Bug 39616 has been marked as a duplicate of this bug. ***
UCS4.1-0: r65082: * Fixed SAML tests (Bug #39657) * Make sure a master is running if needed * Don't use a fixed date * moved to folder 82_saml/ Package: ucs-test Version: 6.0.12-8.1313.201511021353
UCS4.1-0: r65105: * use isoformat for date in 82_saml/11_saml_user_expire Package: ucs-test Version: 6.0.12-10.1315.201511031019
Looks good! It would be nice to have some idea of what exactly is being tested if the test succeeds (or fails). Just a print with some sort of progress information would be sufficient, e.g., "Requesting login at UMC..." or "Sending login information at IdP...".
UCS4.1-0: r65250: * Fix bug in error handling (Bug #39657) * Enhanced verbosity Package: ucs-test Version: 6.0.13-3.1324.201511051758
07_sso_global_logout: The following line is incorrect: 37 » » samltest.test_logout(cookies, hostname=master_hostname) As a session on the master exists one isn't automatically logged out of the DC master when one clicks logout on the Slave. The test have to check if the automatic SSO-login doesn't work anymore on all the hosts.
UCS4.1-1: r67607: * 82_saml/05_saml_login check that SAML session is closed after logout Package: ucs-test Version: 6.0.33-16.1427.201602221508
(In reply to Jürn Brodersen from comment #11) > UCS4.1-1: > r67607: * 82_saml/05_saml_login check that SAML session is closed after > logout > Package: ucs-test > Version: 6.0.33-16.1427.201602221508 OK: This looks fine!
Published